public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r11-9702] c++: visibility of local extern [PR103291]
@ 2022-03-28 19:12 Jason Merrill
0 siblings, 0 replies; only message in thread
From: Jason Merrill @ 2022-03-28 19:12 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:10dcd13ff7a9f0fbbae8749929e8808792c76395
commit r11-9702-g10dcd13ff7a9f0fbbae8749929e8808792c76395
Author: Jason Merrill <jason@redhat.com>
Date: Sun Mar 27 09:44:59 2022 -0400
c++: visibility of local extern [PR103291]
When setting up the hidden namespace-scope decl for a local extern, we also
need to set its visibility.
PR c++/103291
gcc/cp/ChangeLog:
* name-lookup.c (push_local_extern_decl_alias): Call
determine_visibility.
gcc/testsuite/ChangeLog:
* g++.dg/ext/visibility/visibility-local-extern1.C: New test.
Diff:
---
gcc/cp/name-lookup.c | 3 +++
gcc/testsuite/g++.dg/ext/visibility/visibility-local-extern1.C | 10 ++++++++++
2 files changed, 13 insertions(+)
diff --git a/gcc/cp/name-lookup.c b/gcc/cp/name-lookup.c
index c9ac3db4d98..e9af670c28f 100644
--- a/gcc/cp/name-lookup.c
+++ b/gcc/cp/name-lookup.c
@@ -3481,6 +3481,9 @@ push_local_extern_decl_alias (tree decl)
&& CP_DECL_THREAD_LOCAL_P (decl)
&& alias != error_mark_node)
set_decl_tls_model (alias, DECL_TLS_MODEL (decl));
+
+ /* Adjust visibility. */
+ determine_visibility (alias);
}
}
diff --git a/gcc/testsuite/g++.dg/ext/visibility/visibility-local-extern1.C b/gcc/testsuite/g++.dg/ext/visibility/visibility-local-extern1.C
new file mode 100644
index 00000000000..40c20199d0c
--- /dev/null
+++ b/gcc/testsuite/g++.dg/ext/visibility/visibility-local-extern1.C
@@ -0,0 +1,10 @@
+// PR c++/103291
+// { dg-additional-options -fpic }
+// { dg-final { scan-assembler-not "@GOTPCREL" } }
+
+#pragma GCC visibility push(hidden)
+
+int hidden_fetch(void) {
+ extern const int hidden_global;
+ return hidden_global;
+}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-03-28 19:12 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-28 19:12 [gcc r11-9702] c++: visibility of local extern [PR103291] Jason Merrill
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).