public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r11-9704] c++: member alias declaration [PR103968]
@ 2022-03-28 19:12 Jason Merrill
0 siblings, 0 replies; only message in thread
From: Jason Merrill @ 2022-03-28 19:12 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:97390a9914672f5ce73c169b3ae7fd4bba25c2fe
commit r11-9704-g97390a9914672f5ce73c169b3ae7fd4bba25c2fe
Author: Jason Merrill <jason@redhat.com>
Date: Sun Mar 27 00:28:30 2022 -0400
c++: member alias declaration [PR103968]
Here, we were wrongly thinking that (const Options&)Widget<T>::c_options is
not value-dependent because neither the type nor the (value of) c_options
are dependent, but since we're binding it to a reference we also need to
consider that it has a value-dependent address.
PR c++/103968
gcc/cp/ChangeLog:
* pt.c (value_dependent_expression_p): Check
has_value_dependent_address for conversion to reference.
gcc/testsuite/ChangeLog:
* g++.dg/cpp0x/alias-decl-mem1.C: New test.
Diff:
---
gcc/cp/pt.c | 4 ++++
gcc/testsuite/g++.dg/cpp0x/alias-decl-mem1.C | 20 ++++++++++++++++++++
2 files changed, 24 insertions(+)
diff --git a/gcc/cp/pt.c b/gcc/cp/pt.c
index 1493019bd27..b80d3d13600 100644
--- a/gcc/cp/pt.c
+++ b/gcc/cp/pt.c
@@ -26987,6 +26987,10 @@ value_dependent_expression_p (tree expression)
if (TREE_CODE (expression) == TREE_LIST)
return any_value_dependent_elements_p (expression);
+ if (TREE_CODE (type) == REFERENCE_TYPE
+ && has_value_dependent_address (expression))
+ return true;
+
return value_dependent_expression_p (expression);
}
diff --git a/gcc/testsuite/g++.dg/cpp0x/alias-decl-mem1.C b/gcc/testsuite/g++.dg/cpp0x/alias-decl-mem1.C
new file mode 100644
index 00000000000..3e422de4054
--- /dev/null
+++ b/gcc/testsuite/g++.dg/cpp0x/alias-decl-mem1.C
@@ -0,0 +1,20 @@
+// PR c++/103968
+// { dg-do compile { target c++11 } }
+
+template <typename Opt, Opt const& options>
+struct trait
+{
+ template <typename T>
+ struct NonInstantiated{};
+};
+
+struct Options {};
+
+template <typename T>
+struct Widget
+{
+ static constexpr auto c_options = Options{};
+ using Trait = trait<decltype(c_options), c_options>;
+};
+
+Widget<int>::Trait b{}; // Crashes GCC > 10.3
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-03-28 19:12 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-28 19:12 [gcc r11-9704] c++: member alias declaration [PR103968] Jason Merrill
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).