public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r12-8099] c++: rodata and defaulted ctor [PR104142]
@ 2022-04-12 3:58 Jason Merrill
0 siblings, 0 replies; only message in thread
From: Jason Merrill @ 2022-04-12 3:58 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:0899b22d9329c1e8fc12d6f0deee0f87dcc0163a
commit r12-8099-g0899b22d9329c1e8fc12d6f0deee0f87dcc0163a
Author: Jason Merrill <jason@redhat.com>
Date: Mon Apr 11 14:50:14 2022 -0400
c++: rodata and defaulted ctor [PR104142]
Trivial initialization shouldn't bump a variable out of .rodata; if the
result of build_aggr_init is an empty STATEMENT_LIST, throw it away.
PR c++/104142
gcc/cp/ChangeLog:
* decl.cc (check_initializer): Check TREE_SIDE_EFFECTS.
gcc/testsuite/ChangeLog:
* g++.dg/opt/const7.C: New test.
Diff:
---
gcc/cp/decl.cc | 4 ++++
gcc/testsuite/g++.dg/opt/const7.C | 7 +++++++
2 files changed, 11 insertions(+)
diff --git a/gcc/cp/decl.cc b/gcc/cp/decl.cc
index c136dbbba1a..31cae4d1d36 100644
--- a/gcc/cp/decl.cc
+++ b/gcc/cp/decl.cc
@@ -7444,6 +7444,10 @@ check_initializer (tree decl, tree init, int flags, vec<tree, va_gc> **cleanups)
if (init && init != error_mark_node)
init_code = build2 (INIT_EXPR, type, decl, init);
+ if (init_code && !TREE_SIDE_EFFECTS (init_code)
+ && init_code != error_mark_node)
+ init_code = NULL_TREE;
+
if (init_code)
{
/* We might have set these in cp_finish_decl. */
diff --git a/gcc/testsuite/g++.dg/opt/const7.C b/gcc/testsuite/g++.dg/opt/const7.C
new file mode 100644
index 00000000000..5bcf94897a8
--- /dev/null
+++ b/gcc/testsuite/g++.dg/opt/const7.C
@@ -0,0 +1,7 @@
+// PR c++/104142
+// { dg-do compile { target c++11 } }
+// { dg-additional-options -Wunused-variable }
+
+struct B { B()=default; };
+static const B b_var; // { dg-bogus "" }
+// { dg-final { scan-assembler-symbol-section {b_var} {^\.(const|rodata)|\[RO\]} } }
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-04-12 3:58 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-12 3:58 [gcc r12-8099] c++: rodata and defaulted ctor [PR104142] Jason Merrill
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).