public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r12-8153] c++: alignment of local typedef in template [PR65211]
@ 2022-04-14  2:56 Jason Merrill
  0 siblings, 0 replies; only message in thread
From: Jason Merrill @ 2022-04-14  2:56 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:8369b4e4c6433535981d377edc1d4abb799c9225

commit r12-8153-g8369b4e4c6433535981d377edc1d4abb799c9225
Author: Jason Merrill <jason@redhat.com>
Date:   Wed Apr 13 21:56:03 2022 -0400

    c++: alignment of local typedef in template [PR65211]
    
    Because common_handle_aligned_attribute only applies the alignment to the
    TREE_TYPE of a typedef, not the DECL_ORIGINAL_TYPE, we need to copy it
    explicitly in tsubst.
    
            PR c++/65211
    
    gcc/cp/ChangeLog:
    
            * pt.cc (tsubst_decl) [TYPE_DECL]: Copy TYPE_ALIGN.
    
    gcc/testsuite/ChangeLog:
    
            * g++.target/i386/vec-tmpl1.C: New test.

Diff:
---
 gcc/cp/pt.cc                              |  6 ++++++
 gcc/testsuite/g++.target/i386/vec-tmpl1.C | 16 ++++++++++++++++
 2 files changed, 22 insertions(+)

diff --git a/gcc/cp/pt.cc b/gcc/cp/pt.cc
index adc863de702..dde62ee052d 100644
--- a/gcc/cp/pt.cc
+++ b/gcc/cp/pt.cc
@@ -15084,6 +15084,12 @@ tsubst_decl (tree t, tree args, tsubst_flags_t complain)
 	  {
 	    DECL_ORIGINAL_TYPE (r) = NULL_TREE;
 	    set_underlying_type (r);
+
+	    /* common_handle_aligned_attribute doesn't apply the alignment
+	       to DECL_ORIGINAL_TYPE.  */
+	    if (TYPE_USER_ALIGN (TREE_TYPE (t)))
+	      TREE_TYPE (r) = build_aligned_type (TREE_TYPE (r),
+						  TYPE_ALIGN (TREE_TYPE (t)));
 	  }
 
 	layout_decl (r, 0);
diff --git a/gcc/testsuite/g++.target/i386/vec-tmpl1.C b/gcc/testsuite/g++.target/i386/vec-tmpl1.C
new file mode 100644
index 00000000000..d512072a2a2
--- /dev/null
+++ b/gcc/testsuite/g++.target/i386/vec-tmpl1.C
@@ -0,0 +1,16 @@
+// PR c++/65211
+// { dg-final { scan-assembler-not "movdqa" } }
+
+typedef unsigned v4ui __attribute__ ((vector_size(16), aligned (16)));
+
+template<int I>
+static v4ui t1(unsigned *dest_data)
+{
+  typedef unsigned v4ui_1 __attribute__ ((vector_size (16), aligned (4)));
+  return ((const v4ui_1*)dest_data)[0];
+}
+
+v4ui f(unsigned int *array)
+{
+    return t1<1>(array+7);
+}


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-04-14  2:56 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-14  2:56 [gcc r12-8153] c++: alignment of local typedef in template [PR65211] Jason Merrill

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).