public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r10-10695] aarch64: Fix up RTL sharing bug in aarch64_load_symref_appropriately [PR104910]
@ 2022-05-10 8:25 Jakub Jelinek
0 siblings, 0 replies; only message in thread
From: Jakub Jelinek @ 2022-05-10 8:25 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:c9b590a80fbe16a118acdbab15e6f82853db6806
commit r10-10695-gc9b590a80fbe16a118acdbab15e6f82853db6806
Author: Jakub Jelinek <jakub@redhat.com>
Date: Wed Mar 16 11:04:16 2022 +0100
aarch64: Fix up RTL sharing bug in aarch64_load_symref_appropriately [PR104910]
We unshare all RTL created during expansion, but when
aarch64_load_symref_appropriately is called after expansion like in the
following testcases, we use imm in both HIGH and LO_SUM operands.
If imm is some RTL that shouldn't be shared like a non-sharable CONST,
we get at least with --enable-checking=rtl a checking ICE, otherwise might
just get silently wrong code.
The following patch fixes that by copying it if it can't be shared.
2022-03-16 Jakub Jelinek <jakub@redhat.com>
PR target/104910
* config/aarch64/aarch64.c (aarch64_load_symref_appropriately): Copy
imm rtx.
* gcc.dg/pr104910.c: New test.
(cherry picked from commit 952155629ca1a4dfe7c7b26e53d118a9b853ed4a)
Diff:
---
gcc/config/aarch64/aarch64.c | 2 +-
gcc/testsuite/gcc.dg/pr104910.c | 14 ++++++++++++++
2 files changed, 15 insertions(+), 1 deletion(-)
diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c
index 1e08f4caa11..d934dd67fc5 100644
--- a/gcc/config/aarch64/aarch64.c
+++ b/gcc/config/aarch64/aarch64.c
@@ -3123,7 +3123,7 @@ aarch64_load_symref_appropriately (rtx dest, rtx imm,
if (can_create_pseudo_p ())
tmp_reg = gen_reg_rtx (mode);
- emit_move_insn (tmp_reg, gen_rtx_HIGH (mode, imm));
+ emit_move_insn (tmp_reg, gen_rtx_HIGH (mode, copy_rtx (imm)));
emit_insn (gen_add_losym (dest, tmp_reg, imm));
return;
}
diff --git a/gcc/testsuite/gcc.dg/pr104910.c b/gcc/testsuite/gcc.dg/pr104910.c
new file mode 100644
index 00000000000..10fed8147de
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/pr104910.c
@@ -0,0 +1,14 @@
+/* PR target/104910 */
+/* { dg-do compile } */
+/* { dg-options "-Os -fno-forward-propagate" } */
+/* { dg-additional-options "-fstack-protector-all" { target fstack_protector } } */
+
+void
+bar (void);
+
+void
+foo (int x)
+{
+ if (x)
+ bar ();
+}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-05-10 8:25 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-10 8:25 [gcc r10-10695] aarch64: Fix up RTL sharing bug in aarch64_load_symref_appropriately [PR104910] Jakub Jelinek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).