public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r10-10706] c-family: Initialize ridpointers for __int128 etc. [PR105186]
@ 2022-05-10 8:26 Jakub Jelinek
0 siblings, 0 replies; only message in thread
From: Jakub Jelinek @ 2022-05-10 8:26 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:73f5db083a73c6125e0203ea50c4d1f0a1c6421a
commit r10-10706-g73f5db083a73c6125e0203ea50c4d1f0a1c6421a
Author: Jakub Jelinek <jakub@redhat.com>
Date: Mon Apr 11 10:41:07 2022 +0200
c-family: Initialize ridpointers for __int128 etc. [PR105186]
The following testcase ICEs with C++ and is incorrectly rejected with C.
The reason is that both FEs use ridpointers identifiers for CPP_KEYWORD
and value or u.value for CPP_NAME e.g. when parsing attributes or OpenMP
directives etc., like:
/* Save away the identifier that indicates which attribute
this is. */
identifier = (token->type == CPP_KEYWORD)
/* For keywords, use the canonical spelling, not the
parsed identifier. */
? ridpointers[(int) token->keyword]
: id_token->u.value;
identifier = canonicalize_attr_name (identifier);
I've tried to change those to use ridpointers only if non-NULL and otherwise
use the value/u.value even for CPP_KEYWORDS, but that was a large 10 hunks
patch.
The following patch instead just initializes ridpointers for the __intNN
keywords. It can't be done earlier before we record_builtin_type as there
are 2 different spellings and if we initialize those ridpointers early, the
second record_builtin_type fails miserably.
2022-04-11 Jakub Jelinek <jakub@redhat.com>
PR c++/105186
* c-common.c (c_common_nodes_and_builtins): After registering __int%d
and __int%d__ builtin types, initialize corresponding ridpointers
entry.
* c-c++-common/pr105186.c: New test.
(cherry picked from commit 083e8e66d2e90992fa83a53bfc3553dfa91abda1)
Diff:
---
gcc/c-family/c-common.c | 2 ++
gcc/testsuite/c-c++-common/pr105186.c | 5 +++++
2 files changed, 7 insertions(+)
diff --git a/gcc/c-family/c-common.c b/gcc/c-family/c-common.c
index ad8bdc34a56..8105a27ab56 100644
--- a/gcc/c-family/c-common.c
+++ b/gcc/c-family/c-common.c
@@ -4031,6 +4031,8 @@ c_common_nodes_and_builtins (void)
sprintf (name, "__int%d__", int_n_data[i].bitsize);
record_builtin_type ((enum rid)(RID_FIRST_INT_N + i), name,
int_n_trees[i].signed_type);
+ ridpointers[RID_FIRST_INT_N + i]
+ = DECL_NAME (TYPE_NAME (int_n_trees[i].signed_type));
sprintf (name, "__int%d unsigned", int_n_data[i].bitsize);
record_builtin_type (RID_MAX, name, int_n_trees[i].unsigned_type);
diff --git a/gcc/testsuite/c-c++-common/pr105186.c b/gcc/testsuite/c-c++-common/pr105186.c
new file mode 100644
index 00000000000..ea687eacc4c
--- /dev/null
+++ b/gcc/testsuite/c-c++-common/pr105186.c
@@ -0,0 +1,5 @@
+/* PR c++/105186 */
+/* { dg-do compile } */
+
+__attribute__((__int128)) int i; /* { dg-warning "'__int128' attribute directive ignored" } */
+__attribute__((__int128__)) int j; /* { dg-warning "'__int128' attribute directive ignored" } */
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-05-10 8:26 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-10 8:26 [gcc r10-10706] c-family: Initialize ridpointers for __int128 etc. [PR105186] Jakub Jelinek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).