public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r13-263] Use gimple-match folding in fold_build_cond_expr
@ 2022-05-10 13:43 Richard Biener
0 siblings, 0 replies; only message in thread
From: Richard Biener @ 2022-05-10 13:43 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:9801ca737b1dcbf51c0d07db59dd204a047dd3f7
commit r13-263-g9801ca737b1dcbf51c0d07db59dd204a047dd3f7
Author: Richard Biener <rguenther@suse.de>
Date: Tue May 10 15:39:46 2022 +0200
Use gimple-match folding in fold_build_cond_expr
The following cleans up if-conversions fold_build_cond_expr to
use gimple-match folding instead of GENERIC folding.
2022-05-10 Richard Biener <rguenther@suse.de>
* tree-if-conv.cc (fold_build_cond_expr): Use
match-and-simplify to simplify the condition.
(ifcvt_follow_ssa_use_edges): Remove.
(predicate_scalar_phi): Use follow_all_ssa_edges.
Diff:
---
gcc/tree-if-conv.cc | 46 +++++++++++-----------------------------------
1 file changed, 11 insertions(+), 35 deletions(-)
diff --git a/gcc/tree-if-conv.cc b/gcc/tree-if-conv.cc
index 7495ed653c0..57cc38567d3 100644
--- a/gcc/tree-if-conv.cc
+++ b/gcc/tree-if-conv.cc
@@ -459,8 +459,6 @@ fold_or_predicates (location_t loc, tree c1, tree c2)
static tree
fold_build_cond_expr (tree type, tree cond, tree rhs, tree lhs)
{
- tree rhs1, lhs1, cond_expr;
-
/* If COND is comparison r != 0 and r has boolean type, convert COND
to SSA_NAME to accept by vect bool pattern. */
if (TREE_CODE (cond) == NE_EXPR)
@@ -472,34 +470,20 @@ fold_build_cond_expr (tree type, tree cond, tree rhs, tree lhs)
&& (integer_zerop (op1)))
cond = op0;
}
- cond_expr = fold_ternary (COND_EXPR, type, cond, rhs, lhs);
-
- if (cond_expr == NULL_TREE)
- return build3 (COND_EXPR, type, cond, rhs, lhs);
-
- STRIP_USELESS_TYPE_CONVERSION (cond_expr);
- if (is_gimple_val (cond_expr))
- return cond_expr;
-
- if (TREE_CODE (cond_expr) == ABS_EXPR)
+ gimple_match_op cexpr (gimple_match_cond::UNCOND, COND_EXPR,
+ type, cond, rhs, lhs);
+ if (cexpr.resimplify (NULL, follow_all_ssa_edges))
{
- rhs1 = TREE_OPERAND (cond_expr, 1);
- STRIP_USELESS_TYPE_CONVERSION (rhs1);
- if (is_gimple_val (rhs1))
- return build1 (ABS_EXPR, type, rhs1);
+ if (gimple_simplified_result_is_gimple_val (&cexpr))
+ return cexpr.ops[0];
+ else if (cexpr.code == ABS_EXPR)
+ return build1 (ABS_EXPR, type, cexpr.ops[0]);
+ else if (cexpr.code == MIN_EXPR
+ || cexpr.code == MAX_EXPR)
+ return build2 ((tree_code)cexpr.code, type, cexpr.ops[0], cexpr.ops[1]);
}
- if (TREE_CODE (cond_expr) == MIN_EXPR
- || TREE_CODE (cond_expr) == MAX_EXPR)
- {
- lhs1 = TREE_OPERAND (cond_expr, 0);
- STRIP_USELESS_TYPE_CONVERSION (lhs1);
- rhs1 = TREE_OPERAND (cond_expr, 1);
- STRIP_USELESS_TYPE_CONVERSION (rhs1);
- if (is_gimple_val (rhs1) && is_gimple_val (lhs1))
- return build2 (TREE_CODE (cond_expr), type, lhs1, rhs1);
- }
return build3 (COND_EXPR, type, cond, rhs, lhs);
}
@@ -1897,14 +1881,6 @@ gen_phi_arg_condition (gphi *phi, vec<int> *occur,
return cond;
}
-/* Local valueization callback that follows all-use SSA edges. */
-
-static tree
-ifcvt_follow_ssa_use_edges (tree val)
-{
- return val;
-}
-
/* Replace a scalar PHI node with a COND_EXPR using COND as condition.
This routine can handle PHI nodes with more than two arguments.
@@ -2007,7 +1983,7 @@ predicate_scalar_phi (gphi *phi, gimple_stmt_iterator *gsi)
new_stmt = gimple_build_assign (res, rhs);
gsi_insert_before (gsi, new_stmt, GSI_SAME_STMT);
gimple_stmt_iterator new_gsi = gsi_for_stmt (new_stmt);
- if (fold_stmt (&new_gsi, ifcvt_follow_ssa_use_edges))
+ if (fold_stmt (&new_gsi, follow_all_ssa_edges))
{
new_stmt = gsi_stmt (new_gsi);
update_stmt (new_stmt);
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-05-10 13:43 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-10 13:43 [gcc r13-263] Use gimple-match folding in fold_build_cond_expr Richard Biener
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).