public inbox for gcc-cvs@sourceware.org help / color / mirror / Atom feed
From: Michael Meissner <meissner@gcc.gnu.org> To: gcc-cvs@gcc.gnu.org Subject: [gcc(refs/users/meissner/heads/work089)] Update ChangeLog.meissner. Date: Thu, 12 May 2022 20:53:35 +0000 (GMT) [thread overview] Message-ID: <20220512205335.B15CC395A00B@sourceware.org> (raw) https://gcc.gnu.org/g:bfd76fdcdfb4e019f6f0b30a065e02954fce088b commit bfd76fdcdfb4e019f6f0b30a065e02954fce088b Author: Michael Meissner <meissner@linux.ibm.com> Date: Thu May 12 16:53:18 2022 -0400 Update ChangeLog.meissner. 2022-05-12 Michael Meissner <meissner@linux.ibm.com> gcc/ * ChangeLog.meissner: Update. Diff: --- gcc/ChangeLog.meissner | 86 ++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 86 insertions(+) diff --git a/gcc/ChangeLog.meissner b/gcc/ChangeLog.meissner index 262da62bc6b..58c83a45a1c 100644 --- a/gcc/ChangeLog.meissner +++ b/gcc/ChangeLog.meissner @@ -1,3 +1,89 @@ +==================== work089 patch #2 + +Optimize vec_splats of constant vec_extract for V2DI/V2DF, PR target 99293. + +This is version 2 of the patch. The original patch was: + +| Date: Mon, 28 Mar 2022 12:26:02 -0400 +| Subject: [PATCH 1/4] Optimize vec_splats of constant vec_extract for V2DI/V2DF, PR target 99293. +| Message-ID: <YkHhmvwSJF7DUDhJ@toto.the-meissners.org> +| https://gcc.gnu.org/pipermail/gcc-patches/2022-March/592420.html + +In PR target/99293, it was pointed out that doing: + + vector long long dest0, dest1, src; + /* ... */ + dest0 = vec_splats (vec_extract (src, 0)); + dest1 = vec_splats (vec_extract (src, 1)); + +would generate slower code. + +It generates the following code on power8: + + ;; vec_splats (vec_extract (src, 0)) + xxpermdi 0,34,34,3 + xxpermdi 34,0,0,0 + + ;; vec_splats (vec_extract (src, 1)) + xxlor 0,34,34 + xxpermdi 34,0,0,0 + +However on power9 and power10 it generates: + + ;; vec_splats (vec_extract (src, 0)) + mfvsld 3,34 + mtvsrdd 34,9,9 + + ;; vec_splats (vec_extract (src, 1)) + mfvsrd 9,34 + mtvsrdd 34,9,9 + +This is due to the power9 having the mfvsrld instruction which can extract +either 64-bit element into a GPR. While there are alternatives for both +vector registers and GPR registers, the register allocator prefers to put +DImode into GPR registers. + +However in this case, it is better to have a single combiner pattern that +can generate a single xxpermdi, instead of doing 2 insnsns (the extract +and then the concat). This is particularly true if the two operations are +move from vector register and move to vector register. As Segher pointed +out in a previous version of the patch, the combiner already tries doing +creating a (vec_duplicate (vec_select ...)) pattern, but we didn't provide +one. + +This patch reworks vsx_xxspltd_<mode> for V2DImode and V2DFmode so that it +no longer uses an UNSPEC. Instead it uses VEC_DUPLICATE, which the +combiner checks for. + +I have built Spec 2017 with this patch installed, and the cam4_r benchmark +is the only benchmark that generated different code (3 mfvsrld/mtvsrdd +pairs of instructions were replaced with xxpermdi). + +I have built bootstrap versions on the following systems and I have run +the regression tests. There were no regressions in the runs: + + Power9 little endian, --with-cpu=power9 + Power10 little endian, --with-cpu=power10 + Power8 big endian, --with-cpu=power8 (both 32-bit & 64-bit tests) + +Can I install this into the trunk? After a burn-in period, can I backport +and install this into GCC 11 and GCC 10 branches? + +2022-05-12 Michael Meissner <meissner@linux.ibm.com> + +gcc/ + PR target/99293 + * config/rs6000/rs6000-p8swap.cc (rtx_is_swappable_p): Remove + UNSPEC_VSX_XXSPLTD case. + * config/rs6000/vsx.md (UNSPEC_VSX_XXSPLTD): Delete. + (vsx_xxspltd_<mode>): Rewrite to use VEC_DUPLICATE. + +gcc/testsuite: + PR target/99293 + * gcc.target/powerpc/builtins-1.c: Update insn count. + * gcc.target/powerpc/pr99293.c: New test. + + ==================== work089 patch #1 Eliminate power8-fusion and power8-fusion-sign options.
next reply other threads:[~2022-05-12 20:53 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-12 20:53 Michael Meissner [this message] -- strict thread matches above, loose matches on Subject: below -- 2022-05-12 22:56 Michael Meissner 2022-05-12 22:47 Michael Meissner 2022-05-12 22:31 Michael Meissner 2022-05-12 22:22 Michael Meissner 2022-05-11 17:19 Michael Meissner
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220512205335.B15CC395A00B@sourceware.org \ --to=meissner@gcc.gnu.org \ --cc=gcc-cvs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).