public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r13-587] [Ada] Fix incorrect freezing with generic child unit
@ 2022-05-18  8:43 Pierre-Marie de Rodat
  0 siblings, 0 replies; only message in thread
From: Pierre-Marie de Rodat @ 2022-05-18  8:43 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:5488c78c836ca71330bc69247bf75aa14d9d2603

commit r13-587-g5488c78c836ca71330bc69247bf75aa14d9d2603
Author: Marc Poulhiès <poulhies@adacore.com>
Date:   Mon Mar 28 16:03:48 2022 +0200

    [Ada] Fix incorrect freezing with generic child unit
    
    The Analyze_Associations.Check_Generic_Parent function was using an
    incorrect node as the instanciation node for the actual, possibly
    leading to incorrect freeze node being created (and later crashing in
    gigi). Using Get_Unit_Instantiation_Node fixes the issue.
    
    gcc/ada/
    
            * sem_ch12.adb (Check_Generic_Parent): Use
            Get_Unit_Instantiation_Node instead of Next.

Diff:
---
 gcc/ada/sem_ch12.adb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gcc/ada/sem_ch12.adb b/gcc/ada/sem_ch12.adb
index bc083359813..c5f2eed96fd 100644
--- a/gcc/ada/sem_ch12.adb
+++ b/gcc/ada/sem_ch12.adb
@@ -1164,7 +1164,7 @@ package body Sem_Ch12 is
       function Matching_Actual
         (F   : Entity_Id;
          A_F : Entity_Id) return Node_Id;
-      --  Find actual that corresponds to a given a formal parameter. If the
+      --  Find actual that corresponds to a given formal parameter. If the
       --  actuals are positional, return the next one, if any. If the actuals
       --  are named, scan the parameter associations to find the right one.
       --  A_F is the corresponding entity in the analyzed generic, which is
@@ -2063,7 +2063,7 @@ package body Sem_Ch12 is
 
                         procedure Check_Generic_Parent is
                            Inst : constant Node_Id :=
-                                    Next (Unit_Declaration_Node (Actual));
+                                    Get_Unit_Instantiation_Node (Actual);
                            Par  : Entity_Id;
 
                         begin


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-05-18  8:43 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-18  8:43 [gcc r13-587] [Ada] Fix incorrect freezing with generic child unit Pierre-Marie de Rodat

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).