public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r13-722] tree-optimization/105629 - spaceship recognition regression
@ 2022-05-24 6:20 Richard Biener
0 siblings, 0 replies; only message in thread
From: Richard Biener @ 2022-05-24 6:20 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:d918faea1217596877a35c4946500399731fbbd3
commit r13-722-gd918faea1217596877a35c4946500399731fbbd3
Author: Richard Biener <rguenther@suse.de>
Date: Mon May 23 11:41:50 2022 +0200
tree-optimization/105629 - spaceship recognition regression
With the extra GENERIC folding we now do to
(unsigned int) __v._M_value & 1 != (unsigned int) __v._M_value
we end up with a sign-extending conversion to unsigned int
rather than the sign-conversion to unsigned char we expect.
Relaxing that fixes the regression.
2022-05-23 Richard Biener <rguenther@suse.de>
PR tree-optimization/105629
* tree-ssa-phiopt.cc (spaceship_replacement): Allow
a sign-extending conversion.
Diff:
---
gcc/tree-ssa-phiopt.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gcc/tree-ssa-phiopt.cc b/gcc/tree-ssa-phiopt.cc
index 8c9c46d41f1..e61d9736937 100644
--- a/gcc/tree-ssa-phiopt.cc
+++ b/gcc/tree-ssa-phiopt.cc
@@ -2217,7 +2217,7 @@ spaceship_replacement (basic_block cond_bb, basic_block middle_bb,
if (!TYPE_UNSIGNED (ty2) || !INTEGRAL_TYPE_P (ty2))
return false;
- if (TYPE_PRECISION (ty1) != TYPE_PRECISION (ty2))
+ if (TYPE_PRECISION (ty1) > TYPE_PRECISION (ty2))
return false;
if (SSA_NAME_OCCURS_IN_ABNORMAL_PHI (orig_use_lhs))
return false;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-05-24 6:20 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-24 6:20 [gcc r13-722] tree-optimization/105629 - spaceship recognition regression Richard Biener
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).