[gcc(refs/users/egallager/heads/autotools-tinkering)] change some warnings for gcc/configure

[gcc(refs/users/egallager/heads/autotools-tinkering)] change some warnings for gcc/configure

[Eric Gallager]

https://gcc.gnu.org/g:c2caa289485edb40eddcd240a7fc655cfd7c38ba

commit c2caa289485edb40eddcd240a7fc655cfd7c38ba
Author: Eric Gallager <egallager@gcc.gnu.org>
Date:   Wed May 25 01:21:54 2022 -0400

    change some warnings for gcc/configure

Diff:
---
 gcc/configure    | 18 ++++++++++++------
 gcc/configure.ac | 18 ++++++++++++------
 2 files changed, 24 insertions(+), 12 deletions(-)

diff --git a/gcc/configure b/gcc/configure
index 232f5ea9c50..c4db8767d68 100755
--- a/gcc/configure
+++ b/gcc/configure
@@ -1712,7 +1712,7 @@ Optional Features:
   --disable-rpath         do not hardcode runtime library paths
   --enable-sjlj-exceptions
                           arrange to use setjmp/longjmp exception handling
-  --enable-secureplt      enable -msecure-plt by default for PowerPC
+  --enable-secureplt      enable -msecure-plt by default for PowerPC ELF
   --enable-mingw-wildcard Set whether to expand wildcard on command-line.
                           Default to platform configuration
   --enable-large-address-aware
@@ -7089,7 +7089,7 @@ ac_compiler_gnu=$ac_cv_cxx_compiler_gnu
 
 loose_warn=
 save_CXXFLAGS="$CXXFLAGS"
-for real_option in -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual $wf_opt; do
+for real_option in -Wall -Wextra -Wnarrowing -Wwrite-strings -Wcast-qual $wf_opt; do
   # Do the check with the no- prefix removed since gcc silently
   # accepts any -Wno-* option on purpose
   case $real_option in
@@ -7348,7 +7348,7 @@ fi
 { $as_echo "$as_me:${as_lineno-$LINENO}: result: $acx_cv_prog_cc_pedantic__Wlong_long__Wvariadic_macros__Woverlength_strings" >&5
 $as_echo "$acx_cv_prog_cc_pedantic__Wlong_long__Wvariadic_macros__Woverlength_strings" >&6; }
 if test $acx_cv_prog_cc_pedantic__Wlong_long__Wvariadic_macros__Woverlength_strings = yes; then :
-  strict_warn="$strict_warn${strict_warn:+ }-pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings"
+  strict_warn="$strict_warn${strict_warn:+ }-pedantic -Wno-long-long -Wno-variadic-macros -Woverlength-strings"
 fi
 
 fi
@@ -13183,12 +13183,16 @@ esac
 # Check whether --enable-secureplt was given.
 if test "${enable_secureplt+set}" = set; then :
   enableval=$enable_secureplt;
+# TODO: reject on unsupported platforms
+
 fi
 
 
 # Check whether --enable-mingw-wildcard was given.
 if test "${enable_mingw_wildcard+set}" = set; then :
   enableval=$enable_mingw_wildcard;
+# TODO: only allow on mingw
+
 else
   enable_mingw_wildcard=platform
 fi
@@ -19682,7 +19686,7 @@ else
   lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2
   lt_status=$lt_dlunknown
   cat > conftest.$ac_ext <<_LT_EOF
-#line 19685 "configure"
+#line 19689 "configure"
 #include "confdefs.h"
 
 #if HAVE_DLFCN_H
@@ -19788,7 +19792,7 @@ else
   lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2
   lt_status=$lt_dlunknown
   cat > conftest.$ac_ext <<_LT_EOF
-#line 19791 "configure"
+#line 19795 "configure"
 #include "confdefs.h"
 
 #if HAVE_DLFCN_H
@@ -29835,7 +29839,9 @@ _ACEOF
 # Check whether --enable-gnu-unique-object was given.
 if test "${enable_gnu_unique_object+set}" = set; then :
   enableval=$enable_gnu_unique_object; case $enable_gnu_unique_object in
-    yes | no) ;;
+    yes | no)
+      # TODO: warn on unsupported platforms
+      ;;
     *) as_fn_error $? "'$enable_gnu_unique_object' is an invalid value for --enable-gnu-unique-object.
 Valid choices are 'yes' and 'no'." "$LINENO" 5 ;;
   esac
diff --git a/gcc/configure.ac b/gcc/configure.ac
index c396c7b41df..3eb4b336518 100644
--- a/gcc/configure.ac
+++ b/gcc/configure.ac
@@ -572,7 +572,7 @@ AC_ARG_ENABLE(build-format-warnings,
 AS_IF([test $enable_build_format_warnings = no],
       [wf_opt=-Wno-format],[wf_opt=])
 ACX_PROG_CXX_WARNING_OPTS(
-	m4_quote(m4_do([-W -Wall -Wno-narrowing -Wwrite-strings ],
+	m4_quote(m4_do([-Wall -Wextra -Wnarrowing -Wwrite-strings ],
 		       [-Wcast-qual $wf_opt])),
 		       [loose_warn])
 ACX_PROG_CC_WARNING_OPTS(
@@ -585,7 +585,7 @@ ACX_PROG_CC_WARNING_OPTS(
 	m4_quote(m4_do([-Wold-style-definition -Wc++-compat])), [c_strict_warn])
 ACX_PROG_CXX_WARNING_ALMOST_PEDANTIC(
 	m4_quote(m4_do([-Wno-long-long -Wno-variadic-macros ], 
-		       [-Wno-overlength-strings])), [strict_warn])
+		       [-Woverlength-strings])), [strict_warn])
 ACX_PROG_CXX_WARNINGS_ARE_ERRORS([manual], [strict_warn])
 
 # The above macros do nothing if the compiler is not GCC.  However, the
@@ -2212,14 +2212,18 @@ esac
 
 AC_ARG_ENABLE(secureplt,
 [AS_HELP_STRING([--enable-secureplt],
-		[enable -msecure-plt by default for PowerPC])],
-[], [])
+		[enable -msecure-plt by default for PowerPC ELF])],
+[
+# TODO: reject on unsupported platforms
+], [])
 
 AC_ARG_ENABLE(mingw-wildcard,
 [AS_HELP_STRING([--enable-mingw-wildcard],
 		[Set whether to expand wildcard on command-line.
 		 Default to platform configuration])],
-[],[enable_mingw_wildcard=platform])
+[
+# TODO: only allow on mingw
+],[enable_mingw_wildcard=platform])
 AS_IF([test x"$enable_mingw_wildcard" != xplatform ],
       [AC_DEFINE_UNQUOTED(MINGW_DOWILDCARD,
 		 $(test x"$enable_mingw_wildcard" = xno; echo $?),
@@ -5823,7 +5827,9 @@ AC_ARG_ENABLE(gnu-unique-object,
  [AS_HELP_STRING([--enable-gnu-unique-object],
    [enable the use of the @gnu_unique_object ELF extension on glibc systems])],
  [case $enable_gnu_unique_object in
-    yes | no) ;;
+    yes | no)
+      # TODO: warn on unsupported platforms
+      ;;
     *) AC_MSG_ERROR(['$enable_gnu_unique_object' is an invalid value for --enable-gnu-unique-object.
 Valid choices are 'yes' and 'no'.]) ;;
   esac],