public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Jan Beulich <jbeulich@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r13-853] x86: correct bmi2_umul<mode><dwi>3_1's MEM_P() uses
Date: Mon, 30 May 2022 09:30:06 +0000 (GMT)	[thread overview]
Message-ID: <20220530093007.009DF384B0CA@sourceware.org> (raw)

https://gcc.gnu.org/g:c89298404071e3b42eb7e2bfbdbaa45573538b53

commit r13-853-gc89298404071e3b42eb7e2bfbdbaa45573538b53
Author: Jan Beulich <jbeulich@suse.com>
Date:   Mon May 30 11:29:59 2022 +0200

    x86: correct bmi2_umul<mode><dwi>3_1's MEM_P() uses
    
    It's pretty clear that the operand numbers in the MEM_P() checks are
    off by one, perhaps due to a copy-and-paste oversight (unlike in most
    other places here we're dealing with two outputs).
    
    gcc/
    
            * config/i386/i386.md (bmi2_umul<mode><dwi>3_1): Correct MEM_P()
            arguments.

Diff:
---
 gcc/config/i386/i386.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/config/i386/i386.md b/gcc/config/i386/i386.md
index 602dfa799bf..17bdbd93c4b 100644
--- a/gcc/config/i386/i386.md
+++ b/gcc/config/i386/i386.md
@@ -8465,7 +8465,7 @@
 			(zero_extend:<DWI> (match_dup 3)))
 	    (match_operand:QI 4 "const_int_operand" "n"))))]
   "TARGET_BMI2 && INTVAL (operands[4]) == <MODE_SIZE> * BITS_PER_UNIT
-   && !(MEM_P (operands[1]) && MEM_P (operands[2]))"
+   && !(MEM_P (operands[2]) && MEM_P (operands[3]))"
   "mulx\t{%3, %0, %1|%1, %0, %3}"
   [(set_attr "type" "imulx")
    (set_attr "prefix" "vex")


                 reply	other threads:[~2022-05-30  9:30 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220530093007.009DF384B0CA@sourceware.org \
    --to=jbeulich@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).