public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r12-8451] middle-end/105711 - properly handle CONST_INT when expanding bitfields
@ 2022-06-02 9:39 Richard Biener
0 siblings, 0 replies; only message in thread
From: Richard Biener @ 2022-06-02 9:39 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:cdd93e5b88e6aab832509d7aabed6cfd2d014c58
commit r12-8451-gcdd93e5b88e6aab832509d7aabed6cfd2d014c58
Author: Richard Biener <rguenther@suse.de>
Date: Tue May 24 10:09:25 2022 +0200
middle-end/105711 - properly handle CONST_INT when expanding bitfields
This is another place where we fail to pass down the mode of a
CONST_INT.
2022-05-24 Richard Biener <rguenther@suse.de>
PR middle-end/105711
* expmed.cc (extract_bit_field_as_subreg): Add op0_mode parameter
and use it.
(extract_bit_field_1): Pass down the mode of op0 to
extract_bit_field_as_subreg.
* gcc.target/i386/pr105711.c: New testcase.
(cherry picked from commit 91c7c5edd2c1d31bf379be1d077b39644391cc31)
Diff:
---
gcc/expmed.cc | 22 +++++++++++++---------
gcc/testsuite/gcc.target/i386/pr105711.c | 12 ++++++++++++
2 files changed, 25 insertions(+), 9 deletions(-)
diff --git a/gcc/expmed.cc b/gcc/expmed.cc
index ed39c88bd04..1bb4da8d094 100644
--- a/gcc/expmed.cc
+++ b/gcc/expmed.cc
@@ -1605,20 +1605,22 @@ extract_bit_field_using_extv (const extraction_insn *extv, rtx op0,
return NULL_RTX;
}
-/* See whether it would be valid to extract the part of OP0 described
- by BITNUM and BITSIZE into a value of mode MODE using a subreg
- operation. Return the subreg if so, otherwise return null. */
+/* See whether it would be valid to extract the part of OP0 with
+ mode OP0_MODE described by BITNUM and BITSIZE into a value of
+ mode MODE using a subreg operation.
+ Return the subreg if so, otherwise return null. */
static rtx
extract_bit_field_as_subreg (machine_mode mode, rtx op0,
+ machine_mode op0_mode,
poly_uint64 bitsize, poly_uint64 bitnum)
{
poly_uint64 bytenum;
if (multiple_p (bitnum, BITS_PER_UNIT, &bytenum)
&& known_eq (bitsize, GET_MODE_BITSIZE (mode))
- && lowpart_bit_field_p (bitnum, bitsize, GET_MODE (op0))
- && TRULY_NOOP_TRUNCATION_MODES_P (mode, GET_MODE (op0)))
- return simplify_gen_subreg (mode, op0, GET_MODE (op0), bytenum);
+ && lowpart_bit_field_p (bitnum, bitsize, op0_mode)
+ && TRULY_NOOP_TRUNCATION_MODES_P (mode, op0_mode))
+ return simplify_gen_subreg (mode, op0, op0_mode, bytenum);
return NULL_RTX;
}
@@ -1777,7 +1779,8 @@ extract_bit_field_1 (rtx str_rtx, poly_uint64 bitsize, poly_uint64 bitnum,
for valid bitsize and bitnum, so we don't need to do that here. */
if (VECTOR_MODE_P (mode))
{
- rtx sub = extract_bit_field_as_subreg (mode, op0, bitsize, bitnum);
+ rtx sub = extract_bit_field_as_subreg (mode, op0, outermode,
+ bitsize, bitnum);
if (sub)
return sub;
}
@@ -1824,9 +1827,10 @@ extract_bit_field_1 (rtx str_rtx, poly_uint64 bitsize, poly_uint64 bitnum,
/* Extraction of a full MODE1 value can be done with a subreg as long
as the least significant bit of the value is the least significant
bit of either OP0 or a word of OP0. */
- if (!MEM_P (op0) && !reverse)
+ if (!MEM_P (op0) && !reverse && op0_mode.exists (&imode))
{
- rtx sub = extract_bit_field_as_subreg (mode1, op0, bitsize, bitnum);
+ rtx sub = extract_bit_field_as_subreg (mode1, op0, imode,
+ bitsize, bitnum);
if (sub)
return convert_extracted_bit_field (sub, mode, tmode, unsignedp);
}
diff --git a/gcc/testsuite/gcc.target/i386/pr105711.c b/gcc/testsuite/gcc.target/i386/pr105711.c
new file mode 100644
index 00000000000..6d07e08138a
--- /dev/null
+++ b/gcc/testsuite/gcc.target/i386/pr105711.c
@@ -0,0 +1,12 @@
+/* { dg-do compile } */
+/* { dg-options "-O2 --param=sccvn-max-alias-queries-per-access=0" } */
+
+int *p, a, b;
+
+void
+foo (_Complex char c)
+{
+ c /= 3040;
+ a %= __builtin_memcmp (1 + &c, p, 1);
+ b = c + __imag__ c;
+}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-06-02 9:39 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-02 9:39 [gcc r12-8451] middle-end/105711 - properly handle CONST_INT when expanding bitfields Richard Biener
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).