public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r13-961] PR target/105791: Add V1TI to V_128_256 for xop_pcmov_v1ti on x86_64.
@ 2022-06-02 17:48 Roger Sayle
0 siblings, 0 replies; only message in thread
From: Roger Sayle @ 2022-06-02 17:48 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:37e4e7f77d8f7b7e911bf611a0f8edbc3a850c7a
commit r13-961-g37e4e7f77d8f7b7e911bf611a0f8edbc3a850c7a
Author: Roger Sayle <roger@nextmovesoftware.com>
Date: Thu Jun 2 18:46:37 2022 +0100
PR target/105791: Add V1TI to V_128_256 for xop_pcmov_v1ti on x86_64.
This patch resolves PR target/105791 which is a regression that was
accidentally introduced for my workaround to PR tree-optimization/10566.
(a deeper problem in GCC's vectorizer creating VEC_COND_EXPR when it
shouldn't). The latest issues is that by providing a vcond_mask_v1tiv1ti
pattern in sse.md, the backend now calls ix86_expand_sse_movcc with
V1TImode operands, which has a special case for TARGET_XOP to generate
a vpcmov instruction. Unfortunately, there wasn't previously a V1TImode
variant, xop_pcmov_v1ti, so we'd ICE.
This is easily fixed by adding V1TImode (and V2TImode) to V_128_256
which is only used for defining XOP's vpcmov instruction. This in turn
requires V1TI (and V2TI) to be supported by <avxsizesuffix> (though
the use if <avxsizesuffix> in the names xop_pcmov_<mode><avxsizesuffix>
seems unnecessary; the mode makes the name unique).
2022-06-02 Roger Sayle <roger@nextmovesoftware.com>
gcc/ChangeLog
PR target/105791
* config/i386/sse.md (V_128_256):Add V1TI and V2TI.
(define_mode_attr avxsizesuffix): Add support for V1TI and V2TI.
gcc/testsuite/ChangeLog
PR target/105791
* gcc.target/i386/pr105791.c: New test case.
Diff:
---
gcc/config/i386/sse.md | 9 +++++----
gcc/testsuite/gcc.target/i386/pr105791.c | 13 +++++++++++++
2 files changed, 18 insertions(+), 4 deletions(-)
diff --git a/gcc/config/i386/sse.md b/gcc/config/i386/sse.md
index c2e046e812c..8b3163fe5e3 100644
--- a/gcc/config/i386/sse.md
+++ b/gcc/config/i386/sse.md
@@ -301,7 +301,8 @@
;; All 128bit and 256bit vector modes
(define_mode_iterator V_128_256
- [V32QI V16QI V16HI V8HI V8SI V4SI V4DI V2DI V16HF V8HF V8SF V4SF V4DF V2DF])
+ [V32QI V16QI V16HI V8HI V8SI V4SI V4DI V2DI V2TI V1TI
+ V16HF V8HF V8SF V4SF V4DF V2DF])
;; All 512bit vector modes
(define_mode_iterator V_512 [V64QI V32HI V16SI V8DI V16SF V8DF])
@@ -897,9 +898,9 @@
(V8HI "sse4_1") (V16HI "avx")])
(define_mode_attr avxsizesuffix
- [(V64QI "512") (V32HI "512") (V16SI "512") (V8DI "512")
- (V32QI "256") (V16HI "256") (V8SI "256") (V4DI "256")
- (V16QI "") (V8HI "") (V4SI "") (V2DI "")
+ [(V64QI "512") (V32HI "512") (V16SI "512") (V8DI "512") (V4TI "512")
+ (V32QI "256") (V16HI "256") (V8SI "256") (V4DI "256") (V2TI "256")
+ (V16QI "") (V8HI "") (V4SI "") (V2DI "") (V1TI "")
(V32HF "512") (V16SF "512") (V8DF "512")
(V16HF "256") (V8SF "256") (V4DF "256")
(V8HF "") (V4SF "") (V2DF "")])
diff --git a/gcc/testsuite/gcc.target/i386/pr105791.c b/gcc/testsuite/gcc.target/i386/pr105791.c
new file mode 100644
index 00000000000..55e278b2dad
--- /dev/null
+++ b/gcc/testsuite/gcc.target/i386/pr105791.c
@@ -0,0 +1,13 @@
+/* { dg-do compile { target int128 } } */
+/* { dg-options "-O2 -mxop" } */
+typedef __int128 __attribute__((__vector_size__ (sizeof (__int128)))) U;
+typedef int __attribute__((__vector_size__ (sizeof (int)))) V;
+
+U u;
+V v;
+
+U
+foo (void)
+{
+ return (0 != __builtin_convertvector (v, U)) <= (0 != u);
+}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-06-02 17:48 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-02 17:48 [gcc r13-961] PR target/105791: Add V1TI to V_128_256 for xop_pcmov_v1ti on x86_64 Roger Sayle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).