public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc/devel/rust/master] Merge #1166
@ 2022-06-08 12:37 Thomas Schwinge
0 siblings, 0 replies; only message in thread
From: Thomas Schwinge @ 2022-06-08 12:37 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:d7c5bbe6af7189a95d1e4f2d4171fd8b53e826b3
commit d7c5bbe6af7189a95d1e4f2d4171fd8b53e826b3
Merge: b74044fb627 e69e162462c
Author: bors[bot] <26634292+bors[bot]@users.noreply.github.com>
Date: Tue Apr 26 08:45:21 2022 +0000
Merge #1166
1166: Support inference of generic parameters on paths behind reference's r=philberty a=philberty
We used a hack in the parser to turn simple cases such as &Foo(..) into:
BorrowExpr
CallExpr(
IdentifierExpr + <Argument-expressions>))
The IdentifierExpr here is parsed as a PathExpression but to simplify
things at the time it seemed logic to see these as identifier expressions
but this is actually a Path and we need to be careful about generic
arguments here. Identifiers are simply identifiers and must not be changed
or coherence of inference variables will become a jumble of inference
variables trying to infer one another inside purely generic code.
This patch leaves the PathInExpressions as Path's instead of trying to be
clever and turn them into identifiers.
Fixes #1165
Co-authored-by: Philip Herron <philip.herron@embecosm.com>
Diff:
gcc/rust/parse/rust-parse-impl.h | 20 --------------------
gcc/testsuite/rust/compile/issue-1165.rs | 5 +++++
2 files changed, 5 insertions(+), 20 deletions(-)
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-06-08 12:37 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-08 12:37 [gcc/devel/rust/master] Merge #1166 Thomas Schwinge
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).