public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc/devel/rust/master] privacy: visibility: Do not use SimplePaths this late
@ 2022-06-08 12:40 Thomas Schwinge
0 siblings, 0 replies; only message in thread
From: Thomas Schwinge @ 2022-06-08 12:40 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:d462ec452a1e6558ddaf071a10d2fb3729f5af73
commit d462ec452a1e6558ddaf071a10d2fb3729f5af73
Author: Arthur Cohen <arthur.cohen@embecosm.com>
Date: Tue Apr 26 10:54:51 2022 +0200
privacy: visibility: Do not use SimplePaths this late
Diff:
---
gcc/rust/privacy/rust-visibility-resolver.cc | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/gcc/rust/privacy/rust-visibility-resolver.cc b/gcc/rust/privacy/rust-visibility-resolver.cc
index 8f5aebadf44..3ab6085ce61 100644
--- a/gcc/rust/privacy/rust-visibility-resolver.cc
+++ b/gcc/rust/privacy/rust-visibility-resolver.cc
@@ -45,6 +45,17 @@ VisibilityResolver::go (HIR::Crate &crate)
}
}
+// FIXME: At this point in the pipeline, we should not be dealing with
+// `AST::SimplePath`s anymore! We need to be dealing with their "resolved
+// counterpart", so probably a NodeId/HirId/DefId.
+
+// static bool
+// resolve_module_path (std::vector<HIR::Module> &module_stack,
+// const AST::SimplePath &restriction, DefId &id)
+// {
+// return false;
+// }
+
bool
VisibilityResolver::resolve_visibility (const HIR::Visibility &visibility,
ModuleVisibility &to_resolve)
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-06-08 12:40 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-08 12:40 [gcc/devel/rust/master] privacy: visibility: Do not use SimplePaths this late Thomas Schwinge
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).