[gcc/devel/rust/master] Merge #1252 #1254

[gcc/devel/rust/master] Merge #1252 #1254

[Thomas Schwinge]

https://gcc.gnu.org/g:ff37b816e74091972c6722cce57338bacec6fb00

commit ff37b816e74091972c6722cce57338bacec6fb00
Merge: 9e61c6eb220 7ebe376bd68 6c0be487686
Author: bors[bot] <26634292+bors[bot]@users.noreply.github.com>
Date:   Wed May 18 15:26:55 2022 +0000

    Merge #1252 #1254
    
    1252: privacy: Handle calls to functions defined in previous ancestors r=CohenArthur a=CohenArthur
    
    Previously, we would only check if `current_module` was a direct
    descendant of the item's module. However, we also need to visit each of this
    item's module's children recursively.
    
    
    1254: issue #1233: Do not rely on the endianness for testing r=CohenArthur a=CohenArthur
    
    This testcase uncovered a very interesting bug requiring a refactor of
    our `AST::Block` class (#1253), but should still be fixed/adapted in the
    meantime so that the BE builds on our buildbot do not fail.
    
    I've tested this newtestcase with a compiler from 74e836599ce80a11b1fe28065ed7aae6ffa3b7e2, which was the commit pointed out in #1233. The same ICE would still trigger, so I can safely say that this is a different exemple showing the same underlying issue. I'll work on fixing #1253 but it is a refactor we need to think about a little.
    
    This should make all the architectures on buildbot happy again!
    
    Co-authored-by: Arthur Cohen <arthur.cohen@embecosm.com>

Diff:

 gcc/rust/privacy/rust-privacy-reporter.cc     | 19 ++++++++++++-------
 gcc/testsuite/rust/compile/macro-issue1233.rs |  6 +++---
 gcc/testsuite/rust/compile/privacy2.rs        | 13 +++++++++++++
 3 files changed, 28 insertions(+), 10 deletions(-)