public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r13-1043] openmp: Call dlopen with "libmemkind.so.0" rather than "libmemkind.so"
@ 2022-06-10 19:21 Jakub Jelinek
0 siblings, 0 replies; only message in thread
From: Jakub Jelinek @ 2022-06-10 19:21 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:1eff4872d2e57c481f7218d25eecbfba647504e1
commit r13-1043-g1eff4872d2e57c481f7218d25eecbfba647504e1
Author: Jakub Jelinek <jakub@redhat.com>
Date: Fri Jun 10 21:19:51 2022 +0200
openmp: Call dlopen with "libmemkind.so.0" rather than "libmemkind.so"
On Thu, Jun 09, 2022 at 12:11:28PM +0200, Thomas Schwinge wrote:
> > This patch adds support for dlopening libmemkind.so
>
> Instead of 'dlopen'ing literally 'libmemkind.so':
> ..., shouldn't this instead 'dlopen' 'libmemkind.so.0'? At least for
> Debian/Ubuntu, the latter ('libmemkind.so.0') is shipped in the "library"
> package:
I agree and I've actually noticed it too right before committing, but I thought
I'll investigate and tweak incrementally because "libmemkind.so"
is what I've actually tested (it is what llvm libomp uses).
Here is the now tested incremental fix.
2022-06-10 Jakub Jelinek <jakub@redhat.com>
* allocator.c (gomp_init_memkind): Call dlopen with "libmemkind.so.0"
rather than "libmemkind.so".
Diff:
---
libgomp/allocator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libgomp/allocator.c b/libgomp/allocator.c
index c96d37891a4..b04820b8cf9 100644
--- a/libgomp/allocator.c
+++ b/libgomp/allocator.c
@@ -99,7 +99,7 @@ static pthread_once_t memkind_data_once = PTHREAD_ONCE_INIT;
static void
gomp_init_memkind (void)
{
- void *handle = dlopen ("libmemkind.so", RTLD_LAZY);
+ void *handle = dlopen ("libmemkind.so.0", RTLD_LAZY);
struct gomp_memkind_data *data;
int i;
static const char *kinds[] = {
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-06-10 19:21 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-10 19:21 [gcc r13-1043] openmp: Call dlopen with "libmemkind.so.0" rather than "libmemkind.so" Jakub Jelinek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).