public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r12-8498] i386: Fix assert in ix86_function_arg [PR105970]
@ 2022-06-20 18:33 Uros Bizjak
  0 siblings, 0 replies; only message in thread
From: Uros Bizjak @ 2022-06-20 18:33 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:ddc9b963ab9f267e8cc54be1fa6fcca2e8b0eb84

commit r12-8498-gddc9b963ab9f267e8cc54be1fa6fcca2e8b0eb84
Author: Uros Bizjak <ubizjak@gmail.com>
Date:   Fri Jun 17 17:01:31 2022 +0200

    i386: Fix assert in ix86_function_arg [PR105970]
    
    The mode of pointer argument should equal ptr_mode, not Pmode.
    
    2022-06-17  Uroš Bizjak  <ubizjak@gmail.com>
    
    gcc/ChangeLog:
    
            PR target/105970
            * config/i386/i386.cc (ix86_function_arg): Assert that
            the mode of pointer argumet is equal to ptr_mode, not Pmode.
    
    gcc/testsuite/ChangeLog:
    
            PR target/105970
            * gcc.target/i386/pr105970.c: New test.
    
    (cherry picked from commit 1f8278bfcfc7f7157bf2b405471e67dd5097636b)

Diff:
---
 gcc/config/i386/i386.cc                  | 2 +-
 gcc/testsuite/gcc.target/i386/pr105970.c | 6 ++++++
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/gcc/config/i386/i386.cc b/gcc/config/i386/i386.cc
index 86752a6516a..83995a8cc6b 100644
--- a/gcc/config/i386/i386.cc
+++ b/gcc/config/i386/i386.cc
@@ -3348,7 +3348,7 @@ ix86_function_arg (cumulative_args_t cum_v, const function_arg_info &arg)
       if (POINTER_TYPE_P (arg.type))
 	{
 	  /* This is the pointer argument.  */
-	  gcc_assert (TYPE_MODE (arg.type) == Pmode);
+	  gcc_assert (TYPE_MODE (arg.type) == ptr_mode);
 	  /* It is at -WORD(AP) in the current frame in interrupt and
 	     exception handlers.  */
 	  reg = plus_constant (Pmode, arg_pointer_rtx, -UNITS_PER_WORD);
diff --git a/gcc/testsuite/gcc.target/i386/pr105970.c b/gcc/testsuite/gcc.target/i386/pr105970.c
new file mode 100644
index 00000000000..326486faebf
--- /dev/null
+++ b/gcc/testsuite/gcc.target/i386/pr105970.c
@@ -0,0 +1,6 @@
+/* PR target/105970 */
+/* { dg-do compile { target { ! ia32 } } } */
+/* { dg-require-effective-target maybe_x32 } */
+/* { dg-options "-mx32 -mgeneral-regs-only -maddress-mode=long" } */
+
+#include "../../gcc.dg/torture/pr68037-1.c"


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-06-20 18:33 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-20 18:33 [gcc r12-8498] i386: Fix assert in ix86_function_arg [PR105970] Uros Bizjak

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).