public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc/devel/omp/gcc-12] Add XFAIL for libgomp.oacc-c-c++-common/data-firstprivate-1.c
@ 2022-06-29 14:36 Kwok Yeung
  0 siblings, 0 replies; only message in thread
From: Kwok Yeung @ 2022-06-29 14:36 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:f6cdb8ccebe5ade91061439f0b9a7830d483eecd

commit f6cdb8ccebe5ade91061439f0b9a7830d483eecd
Author: Kwok Cheung Yeung <kcy@codesourcery.com>
Date:   Tue Mar 24 09:36:42 2020 -0700

    Add XFAIL for libgomp.oacc-c-c++-common/data-firstprivate-1.c
    
    The firstprivate_int optimization changes the semantics of firstprivate
    in this test, so XFAIL it until the correct semantics for firstprivate
    have been decided (PR92036).
    
    2020-03-24  Kwok Cheung Yeung  <kcy@codesourcery.com>
    
            libgomp/
            * testsuite/libgomp.oacc-c-c++-common/data-firstprivate-1.c: XFAIL
            execution test.

Diff:
---
 libgomp/ChangeLog.omp                                             | 5 +++++
 libgomp/testsuite/libgomp.oacc-c-c++-common/data-firstprivate-1.c | 6 ++++++
 2 files changed, 11 insertions(+)

diff --git a/libgomp/ChangeLog.omp b/libgomp/ChangeLog.omp
index dc2e8893756..53943208c91 100644
--- a/libgomp/ChangeLog.omp
+++ b/libgomp/ChangeLog.omp
@@ -1,3 +1,8 @@
+2020-03-24  Kwok Cheung Yeung  <kcy@codesourcery.com>
+
+	* testsuite/libgomp.oacc-c-c++-common/data-firstprivate-1.c: XFAIL
+	execution test.
+
 2019-09-17  Julian Brown  <julian@codesourcery.com>
 	    Kwok Cheung Yeung  <kcy@codesourcery.com>
 
diff --git a/libgomp/testsuite/libgomp.oacc-c-c++-common/data-firstprivate-1.c b/libgomp/testsuite/libgomp.oacc-c-c++-common/data-firstprivate-1.c
index 8900a4e070d..4b88c53fac7 100644
--- a/libgomp/testsuite/libgomp.oacc-c-c++-common/data-firstprivate-1.c
+++ b/libgomp/testsuite/libgomp.oacc-c-c++-common/data-firstprivate-1.c
@@ -1,6 +1,12 @@
 /* Test behavior of 'firstprivate' lexically vs. dynamically nested inside a
    'data' region.  */
 
+/* The firstprivate_int optimization changes the semantics of firstprivate
+   in dynamically_nested_compute_2 to copy-by-value when not using shared
+   memory, leading to the behaviour suggested in PR92036 for this case.  */
+
+/* { dg-xfail-run-if "firstprivate_int" { *-*-* } { "-DACC_MEM_SHARED=0" } } */
+
 #include <stdlib.h>


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-06-29 14:36 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-29 14:36 [gcc/devel/omp/gcc-12] Add XFAIL for libgomp.oacc-c-c++-common/data-firstprivate-1.c Kwok Yeung

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).