public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc/devel/omp/gcc-12] openacc: Warn about "independent" "kernels" loops with data-dependences
@ 2022-06-29 14:42 Kwok Yeung
0 siblings, 0 replies; only message in thread
From: Kwok Yeung @ 2022-06-29 14:42 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:01e6774b725ffa667efd818a46795189a281addf
commit 01e6774b725ffa667efd818a46795189a281addf
Author: Frederik Harwath <frederik@codesourcery.com>
Date: Tue Nov 16 16:20:15 2021 +0100
openacc: Warn about "independent" "kernels" loops with data-dependences
This commit concerns loops in OpenACC "kernels" region that have been marked
up with an explicit "independent" clause by the user, but for which Graphite
found data dependences. A discussion on the private internal OpenACC mailing
list suggested that warning the user about the dependences woud be a more
acceptable solution than reverting the user's decision. This behavior is
implemented by the present commit.
gcc/ChangeLog:
* common.opt: Add flag Wopenacc-false-independent.
* omp-offload.cc (oacc_loop_warn_if_false_independent): New function.
(oacc_loop_fixed_partitions): Call from here.
Diff:
---
gcc/ChangeLog.omp | 6 ++++++
gcc/common.opt | 5 +++++
gcc/omp-offload.cc | 49 +++++++++++++++++++++++++++++++++++++++++++++++++
3 files changed, 60 insertions(+)
diff --git a/gcc/ChangeLog.omp b/gcc/ChangeLog.omp
index e79905aa713..46da06d022f 100644
--- a/gcc/ChangeLog.omp
+++ b/gcc/ChangeLog.omp
@@ -1,3 +1,9 @@
+2021-11-16 Andrew Stubbs <ams@codesourcery.com>
+
+ * common.opt: Add flag Wopenacc-false-independent.
+ * omp-offload.cc (oacc_loop_warn_if_false_independent): New function.
+ (oacc_loop_fixed_partitions): Call from here.
+
2021-11-16 Andrew Stubbs <ams@codesourcery.com>
* graphite-isl-ast-to-gimple.cc: Include internal-fn.h.
diff --git a/gcc/common.opt b/gcc/common.opt
index 8511e025174..ea2837c857d 100644
--- a/gcc/common.opt
+++ b/gcc/common.opt
@@ -873,6 +873,11 @@ Wtsan
Common Var(warn_tsan) Init(1) Warning
Warn about unsupported features in ThreadSanitizer.
+Wopenacc-false-independent
+Common Var(warn_openacc_false_independent) Init(1) Warning
+Warn in case a loop in an OpenACC \"kernels\" region has an \"independent\"
+clause but analysis shows that it has loop-carried dependences.
+
Xassembler
Driver Separate
diff --git a/gcc/omp-offload.cc b/gcc/omp-offload.cc
index 25d2038bbd7..b3f534c579d 100644
--- a/gcc/omp-offload.cc
+++ b/gcc/omp-offload.cc
@@ -2054,6 +2054,51 @@ oacc_loop_transform_auto_into_independent (oacc_loop *loop)
return true;
}
+/* Emit a warning if LOOP has an "independent" clause but Graphite's
+ analysis shows that it has data dependences. Note that we respect
+ the user's explicit decision to parallelize the loop but we
+ nevertheless warn that this decision could be wrong. */
+
+static void
+oacc_loop_warn_if_false_independent (oacc_loop *loop)
+{
+ if (!optimize)
+ return;
+
+ if (loop->routine)
+ return;
+
+ /* TODO Warn about "auto" & "independent" in "parallel" regions? */
+ if (!oacc_parallel_kernels_graphite_fun_p ())
+ return;
+
+ if (!(loop->flags & OLF_INDEPENDENT))
+ return;
+
+ bool analyzed = false;
+ bool can_be_parallel = oacc_loop_can_be_parallel_p (loop, analyzed);
+ loop_p cfg_loop = oacc_loop_get_cfg_loop (loop);
+
+ if (cfg_loop && cfg_loop->inner && !analyzed)
+ {
+ if (dump_enabled_p ())
+ {
+ const dump_user_location_t loc
+ = dump_user_location_t::from_location_t (loop->loc);
+ dump_printf_loc (MSG_MISSED_OPTIMIZATION, loc,
+ "'independent' loop in 'kernels' region has not been "
+ "analyzed (cf. 'graphite' "
+ "dumps for more information).\n");
+ }
+ return;
+ }
+
+ if (!can_be_parallel)
+ warning_at (loop->loc, 0,
+ "loop has \"independent\" clause but data dependences were "
+ "found.");
+}
+
/* Walk the OpenACC loop hierarchy checking and assigning the
programmer-specified partitionings. OUTER_MASK is the partitioning
this loop is contained within. Return mask of partitioning
@@ -2105,6 +2150,10 @@ oacc_loop_fixed_partitions (oacc_loop *loop, unsigned outer_mask)
}
}
+ /* TODO Is this flag needed? Perhaps use -Wopenacc-parallelism? */
+ if (warn_openacc_false_independent)
+ oacc_loop_warn_if_false_independent (loop);
+
if (maybe_auto && (loop->flags & OLF_INDEPENDENT))
{
loop->flags |= OLF_AUTO;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-06-29 14:42 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-29 14:42 [gcc/devel/omp/gcc-12] openacc: Warn about "independent" "kernels" loops with data-dependences Kwok Yeung
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).