public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r13-1419] tree-optimization/106055 - issue with autopar
@ 2022-07-04 7:09 Richard Biener
0 siblings, 0 replies; only message in thread
From: Richard Biener @ 2022-07-04 7:09 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:d74d98784a9d0101aad8095d692193a74a2f62f6
commit r13-1419-gd74d98784a9d0101aad8095d692193a74a2f62f6
Author: Richard Biener <rguenther@suse.de>
Date: Fri Jul 1 15:32:30 2022 +0200
tree-optimization/106055 - issue with autopar
When autopar uses graphites canonicalize_loop_closed_ssa it fails to
check whether propagation is allowed and thus it ends up messing up
abnormal constraints.
2022-07-01 Richard Biener <rguenther@suse.de>
PR tree-optimization/106055
* graphite.cc (canonicalize_loop_closed_ssa): Check whether
we can propagate.
* gcc.dg/graphite/pr106055.c: New testcase.
Diff:
---
gcc/graphite.cc | 5 +++-
gcc/testsuite/gcc.dg/graphite/pr106055.c | 41 ++++++++++++++++++++++++++++++++
2 files changed, 45 insertions(+), 1 deletion(-)
diff --git a/gcc/graphite.cc b/gcc/graphite.cc
index a88b13c0219..fd4f7a126e1 100644
--- a/gcc/graphite.cc
+++ b/gcc/graphite.cc
@@ -57,6 +57,7 @@ along with GCC; see the file COPYING3. If not see
#include "tree-ssa-loop-manip.h"
#include "tree-ssa.h"
#include "tree-into-ssa.h"
+#include "tree-ssa-propagate.h"
#include "graphite.h"
/* Print global statistics to FILE. */
@@ -337,7 +338,9 @@ canonicalize_loop_closed_ssa (loop_p loop, edge e)
/* Iterate over the next phis and remove duplicates. */
gsi_next (&gsi);
while (!gsi_end_p (gsi))
- if (gimple_phi_arg_def (phi, 0) == gimple_phi_arg_def (gsi.phi (), 0))
+ if (gimple_phi_arg_def (phi, 0) == gimple_phi_arg_def (gsi.phi (), 0)
+ && may_propagate_copy (gimple_phi_result (gsi.phi ()),
+ gimple_phi_result (phi)))
{
replace_uses_by (gimple_phi_result (gsi.phi ()),
gimple_phi_result (phi));
diff --git a/gcc/testsuite/gcc.dg/graphite/pr106055.c b/gcc/testsuite/gcc.dg/graphite/pr106055.c
new file mode 100644
index 00000000000..22be62b3607
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/graphite/pr106055.c
@@ -0,0 +1,41 @@
+/* { dg-do compile } */
+/* { dg-options "-Os -floop-parallelize-all -fno-tree-dce" } */
+
+__attribute__ ((returns_twice)) int
+bar (void);
+
+void
+quux (void);
+
+void
+empty (void)
+{
+}
+
+unsigned int
+choose (unsigned int x, unsigned int y)
+{
+ return y ? x : 0;
+}
+
+int
+foo (int *p, unsigned int x, int y)
+{
+ unsigned int acc = 0;
+
+ empty ();
+
+ while (x)
+ {
+ bar ();
+ ++x;
+ }
+
+ while (y)
+ acc += y;
+
+ *p = choose (acc, 1);
+ quux ();
+
+ return x;
+}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-07-04 7:09 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-04 7:09 [gcc r13-1419] tree-optimization/106055 - issue with autopar Richard Biener
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).