public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r13-1444] [Ada] Refactor duplicated resolution of Count and Index attributes
@ 2022-07-04  7:51 Pierre-Marie de Rodat
  0 siblings, 0 replies; only message in thread
From: Pierre-Marie de Rodat @ 2022-07-04  7:51 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:e0cd23986ed4fcfbb71ab44959ca18299412e706

commit r13-1444-ge0cd23986ed4fcfbb71ab44959ca18299412e706
Author: Piotr Trojanek <trojanek@adacore.com>
Date:   Tue May 31 12:22:21 2022 +0200

    [Ada] Refactor duplicated resolution of Count and Index attributes
    
    Attribute Index, which was added to Ada 2022 by AI12-0143, is resolved
    just like attribute Count. However, code duplication rightly triggered a
    CodePeer warning.
    
    gcc/ada/
    
            * sem_attr.adb (Resolve_Attribute): Refactor duplicated code for
            Count and Index attributes.

Diff:
---
 gcc/ada/sem_attr.adb | 18 ++++--------------
 1 file changed, 4 insertions(+), 14 deletions(-)

diff --git a/gcc/ada/sem_attr.adb b/gcc/ada/sem_attr.adb
index c0998a5be66..20849bf2088 100644
--- a/gcc/ada/sem_attr.adb
+++ b/gcc/ada/sem_attr.adb
@@ -12300,7 +12300,9 @@ package body Sem_Attr is
          --  if it is an element of an entry family, the index itself may
          --  have to be resolved because it can be a general expression.
 
-         when Attribute_Count =>
+         when Attribute_Count
+            | Attribute_Index
+         =>
             if Nkind (P) = N_Indexed_Component
               and then Is_Entity_Name (Prefix (P))
             then
@@ -12338,19 +12340,7 @@ package body Sem_Attr is
          -- Index --
          -----------
 
-         when Attribute_Index =>
-            if Nkind (P) = N_Indexed_Component
-              and then Is_Entity_Name (Prefix (P))
-            then
-               declare
-                  Indx : constant Node_Id   := First (Expressions (P));
-                  Fam  : constant Entity_Id := Entity (Prefix (P));
-
-               begin
-                  Resolve (Indx, Entry_Index_Type (Fam));
-                  Apply_Scalar_Range_Check (Indx, Entry_Index_Type (Fam));
-               end;
-            end if;
+         --  Processing is shared with Count
 
          ----------------
          -- Loop_Entry --


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-07-04  7:51 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-04  7:51 [gcc r13-1444] [Ada] Refactor duplicated resolution of Count and Index attributes Pierre-Marie de Rodat

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).