public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r13-1611] XFAIL 'offloading_enabled' diagnostics issue in 'libgomp.oacc-c-c++-common/reduction-5.c' [PR101551]
@ 2022-07-12  6:28 Thomas Schwinge
  0 siblings, 0 replies; only message in thread
From: Thomas Schwinge @ 2022-07-12  6:28 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:3723aedaad20a129741c2f6f3c22b3dd1220a3fc

commit r13-1611-g3723aedaad20a129741c2f6f3c22b3dd1220a3fc
Author: Thomas Schwinge <thomas@codesourcery.com>
Date:   Tue Jul 12 08:17:37 2022 +0200

    XFAIL 'offloading_enabled' diagnostics issue in 'libgomp.oacc-c-c++-common/reduction-5.c' [PR101551]
    
    Fix-up for recent commit 06b2a2abe26554c6f9365676683d67368cbba206
    "Enhance '_Pragma' diagnostics verification in OMP C/C++ test cases".
    Supposedly it's the same issue as in
    <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101551#c2>, where I'd
    noted that:
    
    | [...] with an offloading-enabled build of GCC we're losing
    | "note: in expansion of macro '[...]'" diagnostics.
    | (Effectively '-ftrack-macro-expansion=0'?)
    
            PR middle-end/101551
            libgomp/
            * testsuite/libgomp.oacc-c-c++-common/reduction-5.c: XFAIL
            'offloading_enabled' diagnostics issue.

Diff:
---
 libgomp/testsuite/libgomp.oacc-c-c++-common/reduction-5.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/libgomp/testsuite/libgomp.oacc-c-c++-common/reduction-5.c b/libgomp/testsuite/libgomp.oacc-c-c++-common/reduction-5.c
index 72094609f0f..ddccfe89e73 100644
--- a/libgomp/testsuite/libgomp.oacc-c-c++-common/reduction-5.c
+++ b/libgomp/testsuite/libgomp.oacc-c-c++-common/reduction-5.c
@@ -45,10 +45,11 @@ main (void)
 
   /* Nvptx targets require a vector_length or 32 in to allow spinlocks with
      gangs.  */
-  check_reduction (num_workers (nw) vector_length (vl), worker); /* { dg-line check_reduction_loc }
+  check_reduction (num_workers (nw) vector_length (vl), worker); /* { dg-line check_reduction_loc } */
   /* { dg-warning "22:region is vector partitioned but does not contain vector partitioned code" "" { target *-*-* } pragma_loc }
-     { dg-note "1:in expansion of macro 'DO_PRAGMA'" "" { target *-*-* } DO_PRAGMA_loc }
-     { dg-note "3:in expansion of macro 'check_reduction'" "" { target *-*-* } check_reduction_loc } */
+     { dg-note "1:in expansion of macro 'DO_PRAGMA'" "" { target *-*-* xfail offloading_enabled } DO_PRAGMA_loc }
+     { dg-note "3:in expansion of macro 'check_reduction'" "" { target *-*-* xfail offloading_enabled } check_reduction_loc }
+     TODO See PR101551 for 'offloading_enabled' XFAILs.  */
   check_reduction (vector_length (vl), vector);
   check_reduction (num_gangs (ng) num_workers (nw) vector_length (vl), gang
 		   worker vector);


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-07-12  6:28 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-12  6:28 [gcc r13-1611] XFAIL 'offloading_enabled' diagnostics issue in 'libgomp.oacc-c-c++-common/reduction-5.c' [PR101551] Thomas Schwinge

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).