[gcc r13-1695] Fix ICE on view conversion between struct and integer

[gcc r13-1695] Fix ICE on view conversion between struct and integer

[Eric Botcazou]

https://gcc.gnu.org/g:b0f02eeb906b6351099ac97066ef74b6167d9ecb

commit r13-1695-gb0f02eeb906b6351099ac97066ef74b6167d9ecb
Author: Eric Botcazou <ebotcazou@adacore.com>
Date:   Thu Jul 14 12:15:35 2022 +0200

    Fix ICE on view conversion between struct and integer
    
    This happens from prepare_gimple_addressable for the variable to be marked
    with DECL_NOT_GIMPLE_REG_P when its initialization is gimplified, so it's
    apparently just a matter of setting the flag earlier.
    
    gcc/
            * gimplify.cc (lookup_tmp_var): Add NOT_GIMPLE_REG boolean parameter
            and set DECL_NOT_GIMPLE_REG_P on the variable according to it.
            (internal_get_tmp_var): Add NOT_GIMPLE_REG boolean parameter and
            pass it in the call to lookup_tmp_var.
            (get_formal_tmp_var): Pass false in the call to lookup_tmp_var.
            (get_initialized_tmp_var): Likewise.
            (prepare_gimple_addressable): Call internal_get_tmp_var instead of
            get_initialized_tmp_var with NOT_GIMPLE_REG set to true.
    
    gcc/testsuite/
            * gnat.dg/opt98.ads, gnat.dg/opt98.adb: New test.

Diff:
---
 gcc/gimplify.cc                 | 29 ++++++++++++++++-------------
 gcc/testsuite/gnat.dg/opt98.adb | 14 ++++++++++++++
 gcc/testsuite/gnat.dg/opt98.ads | 19 +++++++++++++++++++
 3 files changed, 49 insertions(+), 13 deletions(-)

diff --git a/gcc/gimplify.cc b/gcc/gimplify.cc
index 04990ad91a6..2ac7ca0855e 100644
--- a/gcc/gimplify.cc
+++ b/gcc/gimplify.cc
@@ -573,20 +573,26 @@ create_tmp_from_val (tree val)
 }
 
 /* Create a temporary to hold the value of VAL.  If IS_FORMAL, try to reuse
-   an existing expression temporary.  */
+   an existing expression temporary.  If NOT_GIMPLE_REG, mark it as such.  */
 
 static tree
-lookup_tmp_var (tree val, bool is_formal)
+lookup_tmp_var (tree val, bool is_formal, bool not_gimple_reg)
 {
   tree ret;
 
+  /* We cannot mark a formal temporary with DECL_NOT_GIMPLE_REG_P.  */
+  gcc_assert (!is_formal || !not_gimple_reg);
+
   /* If not optimizing, never really reuse a temporary.  local-alloc
      won't allocate any variable that is used in more than one basic
      block, which means it will go into memory, causing much extra
      work in reload and final and poorer code generation, outweighing
      the extra memory allocation here.  */
   if (!optimize || !is_formal || TREE_SIDE_EFFECTS (val))
-    ret = create_tmp_from_val (val);
+    {
+      ret = create_tmp_from_val (val);
+      DECL_NOT_GIMPLE_REG_P (ret) = not_gimple_reg;
+    }
   else
     {
       elt_t elt, *elt_p;
@@ -617,7 +623,7 @@ lookup_tmp_var (tree val, bool is_formal)
 
 static tree
 internal_get_tmp_var (tree val, gimple_seq *pre_p, gimple_seq *post_p,
-                      bool is_formal, bool allow_ssa)
+		      bool is_formal, bool allow_ssa, bool not_gimple_reg)
 {
   tree t, mod;
 
@@ -639,7 +645,7 @@ internal_get_tmp_var (tree val, gimple_seq *pre_p, gimple_seq *post_p,
 	}
     }
   else
-    t = lookup_tmp_var (val, is_formal);
+    t = lookup_tmp_var (val, is_formal, not_gimple_reg);
 
   mod = build2 (INIT_EXPR, TREE_TYPE (t), t, unshare_expr (val));
 
@@ -667,7 +673,7 @@ internal_get_tmp_var (tree val, gimple_seq *pre_p, gimple_seq *post_p,
 tree
 get_formal_tmp_var (tree val, gimple_seq *pre_p)
 {
-  return internal_get_tmp_var (val, pre_p, NULL, true, true);
+  return internal_get_tmp_var (val, pre_p, NULL, true, true, false);
 }
 
 /* Return a temporary variable initialized with VAL.  PRE_P and POST_P
@@ -678,7 +684,7 @@ get_initialized_tmp_var (tree val, gimple_seq *pre_p,
 			 gimple_seq *post_p /* = NULL */,
 			 bool allow_ssa /* = true */)
 {
-  return internal_get_tmp_var (val, pre_p, post_p, false, allow_ssa);
+  return internal_get_tmp_var (val, pre_p, post_p, false, allow_ssa, false);
 }
 
 /* Declare all the variables in VARS in SCOPE.  If DEBUG_INFO is true,
@@ -4574,13 +4580,10 @@ prepare_gimple_addressable (tree *expr_p, gimple_seq *seq_p)
 {
   while (handled_component_p (*expr_p))
     expr_p = &TREE_OPERAND (*expr_p, 0);
+
+  /* Do not allow an SSA name as the temporary.  */
   if (is_gimple_reg (*expr_p))
-    {
-      /* Do not allow an SSA name as the temporary.  */
-      tree var = get_initialized_tmp_var (*expr_p, seq_p, NULL, false);
-      DECL_NOT_GIMPLE_REG_P (var) = 1;
-      *expr_p = var;
-    }
+    *expr_p = internal_get_tmp_var (*expr_p, seq_p, NULL, false, false, true);
 }
 
 /* A subroutine of gimplify_modify_expr.  Replace a MODIFY_EXPR with
diff --git a/gcc/testsuite/gnat.dg/opt98.adb b/gcc/testsuite/gnat.dg/opt98.adb
new file mode 100644
index 00000000000..6d42338605c
--- /dev/null
+++ b/gcc/testsuite/gnat.dg/opt98.adb
@@ -0,0 +1,14 @@
+-- { dg-do compile }
+-- { dg-options "-O -gnatws" }
+
+package body Opt98 is
+
+  function Func return Rec is
+    R :Rec;
+  begin
+    A := To_Address ((I => 0));
+    R := To_Rec (A);
+    return R;
+  end;
+
+end Opt98;
diff --git a/gcc/testsuite/gnat.dg/opt98.ads b/gcc/testsuite/gnat.dg/opt98.ads
new file mode 100644
index 00000000000..fcc705776d4
--- /dev/null
+++ b/gcc/testsuite/gnat.dg/opt98.ads
@@ -0,0 +1,19 @@
+with Ada.Unchecked_Conversion;
+with System;
+
+package Opt98 is
+
+  type Rec is record
+    I : Integer;
+  end record;
+
+  function To_Address is new Ada.Unchecked_Conversion (Rec, System.Address);
+
+  function To_Rec is new Ada.Unchecked_Conversion (System.Address, Rec);
+
+  A : System.Address with Atomic;
+
+  function Func return Rec;
+
+end Opt98;
+