public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r13-1773] analyzer: fix ICE on untracked decl_regions [PR106374]
@ 2022-07-21  1:39 David Malcolm
  0 siblings, 0 replies; only message in thread
From: David Malcolm @ 2022-07-21  1:39 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:a6c192e80a87efbe6c0641f25a963c7bee9990fb

commit r13-1773-ga6c192e80a87efbe6c0641f25a963c7bee9990fb
Author: David Malcolm <dmalcolm@redhat.com>
Date:   Wed Jul 20 21:34:03 2022 -0400

    analyzer: fix ICE on untracked decl_regions [PR106374]
    
    gcc/analyzer/ChangeLog:
            PR analyzer/106374
            * region.cc (decl_region::get_svalue_for_initializer): Bail out on
            untracked regions.
    
    gcc/testsuite/ChangeLog:
            PR analyzer/106374
            * gcc.dg/analyzer/untracked-2.c: New test.
    
    Signed-off-by: David Malcolm <dmalcolm@redhat.com>

Diff:
---
 gcc/analyzer/region.cc                      | 5 +++++
 gcc/testsuite/gcc.dg/analyzer/untracked-2.c | 7 +++++++
 2 files changed, 12 insertions(+)

diff --git a/gcc/analyzer/region.cc b/gcc/analyzer/region.cc
index a8d1ae92deb..b78bf4ec1b7 100644
--- a/gcc/analyzer/region.cc
+++ b/gcc/analyzer/region.cc
@@ -1152,6 +1152,11 @@ decl_region::get_svalue_for_initializer (region_model_manager *mgr) const
       if (binding->symbolic_p ())
 	return NULL;
 
+      /* If we don't care about tracking the content of this region, then
+	 it's unused, and the value doesn't matter.  */
+      if (!tracked_p ())
+	return NULL;
+
       binding_cluster c (this);
       c.zero_fill_region (mgr->get_store_manager (), this);
       return mgr->get_or_create_compound_svalue (TREE_TYPE (m_decl),
diff --git a/gcc/testsuite/gcc.dg/analyzer/untracked-2.c b/gcc/testsuite/gcc.dg/analyzer/untracked-2.c
new file mode 100644
index 00000000000..565a9ccd58e
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/analyzer/untracked-2.c
@@ -0,0 +1,7 @@
+typedef unsigned char u8;
+extern int foo(const u8 *key, unsigned int keylen);
+int test (void)
+{
+  static const u8 default_salt[64];
+  return foo(default_salt, 64);
+}


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-07-21  1:39 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-21  1:39 [gcc r13-1773] analyzer: fix ICE on untracked decl_regions [PR106374] David Malcolm

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).