public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r13-1795] tree-optimization/106403 - fix ICE with VN of .STORE_LANES
@ 2022-07-22  9:27 Richard Biener
  0 siblings, 0 replies; only message in thread
From: Richard Biener @ 2022-07-22  9:27 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:d85e5aeb7665ea941ff0ef7c11bfe1d39986b48a

commit r13-1795-gd85e5aeb7665ea941ff0ef7c11bfe1d39986b48a
Author: Richard Biener <rguenther@suse.de>
Date:   Fri Jul 22 10:13:06 2022 +0200

    tree-optimization/106403 - fix ICE with VN of .STORE_LANES
    
    While .STORE_LANES is not supported by the recent VN patch we were
    still accessing the stored value and valueizing it - but
    internal_fn_stored_value_index does not support .STORE_LANES and
    we failed to honor that case.  Fixed by simply moving the affected
    code below the check for the actual supported internal functions.
    
            PR tree-optimization/106403
            * tree-ssa-sccvn.cc (vn_reference_lookup_3): Move stored
            value valueization after check for IFN_MASKED_STORE or
            IFN_LEN_STORE.

Diff:
---
 gcc/tree-ssa-sccvn.cc | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/gcc/tree-ssa-sccvn.cc b/gcc/tree-ssa-sccvn.cc
index 7d947b55a27..a1f6f309609 100644
--- a/gcc/tree-ssa-sccvn.cc
+++ b/gcc/tree-ssa-sccvn.cc
@@ -3221,11 +3221,6 @@ vn_reference_lookup_3 (ao_ref *ref, tree vuse, void *data_,
     {
       gcall *call = as_a <gcall *> (def_stmt);
       internal_fn fn = gimple_call_internal_fn (call);
-      tree def_rhs = gimple_call_arg (call,
-				      internal_fn_stored_value_index (fn));
-      def_rhs = vn_valueize (def_rhs);
-      if (TREE_CODE (def_rhs) != VECTOR_CST)
-	return (void *)-1;
 
       tree mask = NULL_TREE, len = NULL_TREE, bias = NULL_TREE;
       switch (fn)
@@ -3245,6 +3240,12 @@ vn_reference_lookup_3 (ao_ref *ref, tree vuse, void *data_,
 	default:
 	  return (void *)-1;
 	}
+      tree def_rhs = gimple_call_arg (call,
+				      internal_fn_stored_value_index (fn));
+      def_rhs = vn_valueize (def_rhs);
+      if (TREE_CODE (def_rhs) != VECTOR_CST)
+	return (void *)-1;
+
       ao_ref_init_from_ptr_and_size (&lhs_ref,
 				     vn_valueize (gimple_call_arg (call, 0)),
 				     TYPE_SIZE_UNIT (TREE_TYPE (def_rhs)));


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-07-22  9:27 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-22  9:27 [gcc r13-1795] tree-optimization/106403 - fix ICE with VN of .STORE_LANES Richard Biener

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).