public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r13-1988] AArch64: Fix 128-bit sequential consistency atomic operations.
@ 2022-08-08 13:38 Tamar Christina
  0 siblings, 0 replies; only message in thread
From: Tamar Christina @ 2022-08-08 13:38 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:e6a8ae900b4141bbce1451da8f173d441662782d

commit r13-1988-ge6a8ae900b4141bbce1451da8f173d441662782d
Author: Tamar Christina <tamar.christina@arm.com>
Date:   Mon Aug 8 14:37:00 2022 +0100

    AArch64: Fix 128-bit sequential consistency atomic operations.
    
    The AArch64 implementation of 128-bit atomics is broken.
    
    For 128-bit atomics we rely on pthread barriers to correct guard the address
    in the pointer to get correct memory ordering.  However for 128-bit atomics the
    address under the lock is different from the original pointer.
    
    This means that one of the values under the atomic operation is not protected
    properly and so we fail during when the user has requested sequential
    consistency as there's no barrier to enforce this requirement.
    
    As such users have resorted to adding an
    
    #ifdef GCC
    <emit barrier>
    #endif
    
    around the use of these atomics.
    
    This corrects the issue by issuing a barrier only when __ATOMIC_SEQ_CST was
    requested.  To remedy this performance hit I think we should revisit using a
    similar approach to out-line-atomics for the 128-bit atomics.
    
    Note that I believe I need the empty file due to the include_next chain but
    I am not entirely sure.  I have hand verified that the barriers are inserted
    for atomic seq cst.
    
    libatomic/ChangeLog:
    
            PR target/102218
            * config/aarch64/aarch64-config.h: New file.
            * config/aarch64/host-config.h: New file.

Diff:
---
 libatomic/config/aarch64/aarch64-config.h | 23 ++++++++++++++++
 libatomic/config/aarch64/host-config.h    | 46 +++++++++++++++++++++++++++++++
 2 files changed, 69 insertions(+)

diff --git a/libatomic/config/aarch64/aarch64-config.h b/libatomic/config/aarch64/aarch64-config.h
new file mode 100644
index 00000000000..d3474fa8ff8
--- /dev/null
+++ b/libatomic/config/aarch64/aarch64-config.h
@@ -0,0 +1,23 @@
+/* Copyright (C) 2022 Free Software Foundation, Inc.
+
+   This file is part of the GNU Atomic Library (libatomic).
+
+   Libatomic is free software; you can redistribute it and/or modify it
+   under the terms of the GNU General Public License as published by
+   the Free Software Foundation; either version 3 of the License, or
+   (at your option) any later version.
+
+   Libatomic is distributed in the hope that it will be useful, but WITHOUT ANY
+   WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
+   FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+   more details.
+
+   Under Section 7 of GPL version 3, you are granted additional
+   permissions described in the GCC Runtime Library Exception, version
+   3.1, as published by the Free Software Foundation.
+
+   You should have received a copy of the GNU General Public License and
+   a copy of the GCC Runtime Library Exception along with this program;
+   see the files COPYING3 and COPYING.RUNTIME respectively.  If not, see
+   <http://www.gnu.org/licenses/>.  */
+
diff --git a/libatomic/config/aarch64/host-config.h b/libatomic/config/aarch64/host-config.h
new file mode 100644
index 00000000000..f445a47d25e
--- /dev/null
+++ b/libatomic/config/aarch64/host-config.h
@@ -0,0 +1,46 @@
+/* Copyright (C) 2022 Free Software Foundation, Inc.
+
+   This file is part of the GNU Atomic Library (libatomic).
+
+   Libatomic is free software; you can redistribute it and/or modify it
+   under the terms of the GNU General Public License as published by
+   the Free Software Foundation; either version 3 of the License, or
+   (at your option) any later version.
+
+   Libatomic is distributed in the hope that it will be useful, but WITHOUT ANY
+   WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
+   FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+   more details.
+
+   Under Section 7 of GPL version 3, you are granted additional
+   permissions described in the GCC Runtime Library Exception, version
+   3.1, as published by the Free Software Foundation.
+
+   You should have received a copy of the GNU General Public License and
+   a copy of the GCC Runtime Library Exception along with this program;
+   see the files COPYING3 and COPYING.RUNTIME respectively.  If not, see
+   <http://www.gnu.org/licenses/>.  */
+
+/* Avoiding the DMB (or kernel helper) can be a good thing.  */
+#define WANT_SPECIALCASE_RELAXED
+
+/* Glibc, at least, uses acq_rel in its pthread mutex
+   implementation.  If the user is asking for seq_cst,
+   this is insufficient.  */
+
+static inline void __attribute__((always_inline, artificial))
+pre_seq_barrier(int model)
+{
+  if (model == __ATOMIC_SEQ_CST)
+    __atomic_thread_fence (__ATOMIC_SEQ_CST);
+}
+
+static inline void __attribute__((always_inline, artificial))
+post_seq_barrier(int model)
+{
+  pre_seq_barrier(model);
+}
+
+#define pre_post_seq_barrier 1
+
+#include_next <host-config.h>


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-08-08 13:38 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-08 13:38 [gcc r13-1988] AArch64: Fix 128-bit sequential consistency atomic operations Tamar Christina

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).