public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc/devel/rust/master] Merge #1493
@ 2022-08-29 15:31 Thomas Schwinge
0 siblings, 0 replies; only message in thread
From: Thomas Schwinge @ 2022-08-29 15:31 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:8d1a6deb4e69e7dc162e741377674cf03459bcd9
commit 8d1a6deb4e69e7dc162e741377674cf03459bcd9
Merge: 0f4ec11e8c2 56f503b88a2
Author: bors[bot] <26634292+bors[bot]@users.noreply.github.com>
Date: Mon Aug 22 14:37:10 2022 +0000
Merge #1493
1493: Fix ICE in dyn impl block r=philberty a=philberty
The issue here was that our name resolution assumed qualified path always
has an as clause. We also had missing visitors to generate the canonical path
for impl blocks using dynamic trait objects.
We should investigate implementing the fine-grained visitors for the AST
similar to the ones we have for HIR. This will solve the issue where we
have missing visitors.
Fixes #1249
Co-authored-by: Philip Herron <philip.herron@embecosm.com>
Diff:
gcc/rust/resolve/rust-ast-resolve-item.cc | 40 +++++++++++-------------
gcc/rust/resolve/rust-ast-resolve-path.cc | 3 +-
gcc/rust/resolve/rust-ast-resolve-type.cc | 21 +++++++++++++
gcc/rust/resolve/rust-ast-resolve-type.h | 4 +++
gcc/rust/typecheck/rust-hir-type-check-path.cc | 6 ----
gcc/testsuite/rust/execute/torture/issue-1249.rs | 39 +++++++++++++++++++++++
6 files changed, 84 insertions(+), 29 deletions(-)
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-08-29 15:31 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-29 15:31 [gcc/devel/rust/master] Merge #1493 Thomas Schwinge
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).