public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc(refs/users/meissner/heads/work100)] Update ChangeLog.meissner.
@ 2022-09-09 21:07 Michael Meissner
  0 siblings, 0 replies; 2+ messages in thread
From: Michael Meissner @ 2022-09-09 21:07 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:1958caeba256da4615eeffc83f71380a1f4772ba

commit 1958caeba256da4615eeffc83f71380a1f4772ba
Author: Michael Meissner <meissner@linux.ibm.com>
Date:   Fri Sep 9 17:04:49 2022 -0400

    Update ChangeLog.meissner.
    
    2022-09-09   Michael Meissner  <meissner@linux.ibm.com>
    
    gcc/
    
            * ChangeLog.meissner: Update.

Diff:
---
 gcc/ChangeLog.meissner | 76 ++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 76 insertions(+)

diff --git a/gcc/ChangeLog.meissner b/gcc/ChangeLog.meissner
index 726276a9168..fa224a0d206 100644
--- a/gcc/ChangeLog.meissner
+++ b/gcc/ChangeLog.meissner
@@ -1,3 +1,79 @@
+==================== work100, patch #6
+
+Make __float128 use the _Float128 type.
+
+Currently GCC uses the long double type node for __float128 if long double is
+IEEE 128-bit.  It did not use the node for _Float128.
+
+Problems showed up if you call the nansq function to make a signaling NaN (nansq
+is mapped to nansf128).  Because the type node for _Float128 is different from
+__float128, the machine independent code converts signaling NaNs to quiet NaNs
+if the types are  not compatible.  The following tests used to fail when run on
+a system where long double is IEEE 128-bit:
+
+	gcc.dg/torture/float128-nan.c
+	gcc.target/powerpc/nan128-1.c
+
+This patch makes both __float128 and _Float128 use the same type node.
+
+One side effect of not using the long double type node for __float128 is that we
+must only use KFmode for _Float128/__float128.  The libstdc++ library won't
+build if we use TFmode for _Float128 and __float128 when long double is IEEE
+128-bit.
+
+Another minor side effect is that the f128 round to odd fused multiply-add
+function will not merge negatition with the FMA operation when the type is long
+double.  If the type is __float128 or _Float128, then it will continue to do the
+optimization.  The round to odd functions are defined in terms of __float128
+arguments.  For example:
+
+	long double
+	do_fms (long double a, long double b, long double c)
+	{
+	    return __builtin_fmaf128_round_to_odd (a, b, -c);
+	}
+
+will generate (assuming -mabi=ieeelongdouble):
+
+	xsnegqp 4,4
+	xsmaddqpo 4,2,3
+	xxlor 34,36,36
+
+while:
+
+	__float128
+	do_fms (__float128 a, __float128 b, __float128 c)
+	{
+	    return __builtin_fmaf128_round_to_odd (a, b, -c);
+	}
+
+will generate:
+
+	xsmsubqpo 4,2,3
+	xxlor 34,36,36
+
+2022-09-09   Michael Meissner  <meissner@linux.ibm.com>
+
+gcc/
+
+	* config/rs6000/rs6000-builtin.cc (rs6000_init_builtins): Always use the
+	_Float128 type for __float128.
+	(rs6000_expand_builtin): Only change a KFmode built-in to TFmode, if the
+	built-in passes or returns TFmode.  If the predicate failed because the
+	modes were different, use convert_move to load up the value instead of
+	copy_to_mode_reg.
+	* config/rs6000/rs6000.cc (rs6000_translate_mode_attribute): Don't
+	translate __float128 modes to long double modes (TFmode or TCmode).
+	(rs6000_libgcc_floating_mode_supported_p): Support KFmode all of the
+	time if we support IEEE 128-bit floating point.
+	(rs6000_floatn_mode): _Float128 and _Float128x always uses KFmode.
+
+gcc/testsuite/
+
+	* gcc.target/powerpc/float128-hw12.c: New test.
+	* gcc.target/powerpc/float128-hw13.c: Likewise.
+	* gcc.target/powerpc/float128-hw4.c: Update insns.
+
 ==================== work100, patch #5
 
 Rework 128-bit complex multiply and divide.

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [gcc(refs/users/meissner/heads/work100)] Update ChangeLog.meissner.
@ 2022-09-09 18:34 Michael Meissner
  0 siblings, 0 replies; 2+ messages in thread
From: Michael Meissner @ 2022-09-09 18:34 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:3205a89eb6a0cf37971e266a155b2040cfcdcf3e

commit 3205a89eb6a0cf37971e266a155b2040cfcdcf3e
Author: Michael Meissner <meissner@linux.ibm.com>
Date:   Fri Sep 9 14:31:46 2022 -0400

    Update ChangeLog.meissner.
    
    2022-09-09   Michael Meissner  <meissner@linux.ibm.com>
    
    gcc/
    
            * ChangeLog.meissner: Update.

Diff:
---
 gcc/ChangeLog.meissner | 207 +++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 207 insertions(+)

diff --git a/gcc/ChangeLog.meissner b/gcc/ChangeLog.meissner
index cc266e88e64..726276a9168 100644
--- a/gcc/ChangeLog.meissner
+++ b/gcc/ChangeLog.meissner
@@ -1,3 +1,210 @@
+==================== work100, patch #5
+
+Rework 128-bit complex multiply and divide.
+
+This function reworks how the complex multiply and divide built-in functions are
+done.  Previously we created built-in declarations for doing long double complex
+multiply and divide when long double is IEEE 128-bit.  The old code also did not
+support __ibm128 complex multiply and divide if long double is IEEE 128-bit.
+
+In terms of history, I wrote the original code just as I was starting to test
+GCC on systems where IEEE 128-bit long double was the default.  At the time, we
+had not yet started mangling the built-in function names as a way to bridge
+going from a system with 128-bit IBM long double to 128-bin IEEE long double.
+
+The original code depends on there only being two 128-bit types invovled.  With
+some of the changes that I plan on making, this assumption will no longer be
+true in the future.
+
+The problem is we cannot create two separate built-in functions that resolve to
+the same name.  This is a requirement of add_builtin_function and the C front
+end.  That means for the 3 possible modes (IFmode, KFmode, and TFmode), you can
+only use 2 of them.
+
+This code does not create the built-in declaration with the changed name.
+Instead, it uses the TARGET_MANGLE_DECL_ASSEMBLER_NAME hook to change the name
+before it is written out to the assembler file like it now does for all of the
+other long double built-in functions.
+
+We need to disable using this mapping when we are building libgcc, which is
+creating the multiply and divide functions.  The flag that is used when libgcc
+is built (-fbuilding-libcc) is only available in the C/C++ front ends.  We need
+to remember that we are building libgcc in the rs6000-c.cc support to be able to
+use this later to decided whether to mangle the decl assembler name or not.
+
+When I wrote these patches, I discovered that __ibm128 complex multiply and
+divide had originally not been supported if long double is IEEE 128-bit as it
+would generate calls to __mulic3 and __divic3.  I added tests in the testsuite
+to verify that the correct name (i.e. __multc3 and __divtc3) is used in this
+case.
+
+2022-09-09   Michael Meissner  <meissner@linux.ibm.com>
+
+gcc/
+
+	* config/rs6000/rs6000-c.cc (rs6000_cpu_cpp_builtins): Set
+	building_libgcc.
+	* config/rs6000/rs6000.cc (create_complex_muldiv): Delete.
+	(init_float128_ieee): Delete code to switch complex multiply and divide
+	for long double.
+	(complex_multiply_builtin_code): New helper function.
+	(complex_divide_builtin_code): Likewise.
+	(rs6000_mangle_decl_assembler_name): Add support for mangling the name
+	of complex 128-bit multiply and divide built-in functions.
+	* config/rs6000/rs6000.opt (building_libgcc): New target variable.
+
+gcc/testsuite/
+
+	* gcc.target/powerpc/divic3-1.c: New test.
+	* gcc.target/powerpc/divic3-2.c: Likewise.
+	* gcc.target/powerpc/mulic3-1.c: Likewise.
+	* gcc.target/powerpc/mulic3-2.c: Likewise.
+
+==================== work100, patch #4
+
+Add 'w' suffix for __ibm128 constants.
+
+In the documentation, we mention that 'w' or 'W' can be used as a suffix for
+__ibm128 constants.  We never implemented this.  This patch fixes that.
+
+In addition, the 'q' and 'Q' suffix were changed to use the mode used for the
+__float128 type, instead of knowing whether to use KFmode or TFmode explicitly.
+This will be used in a future patch where we change the mode used for __float128
+on systems where long double is IEEE 128-bit.
+
+2022-09-09   Michael Meissner  <meissner@linux.ibm.com>
+
+gcc/
+
+	* config/rs6000/rs6000.cc (rs6000_c_mode_for_suffix): Allow 'w' or 'W'
+	for __ibm128 constants.
+
+gcc/testsuite/
+
+	* gcc.target/powerpc/ibm128-suffix.c: New test.
+
+==================== work100, patch #3
+
+Allow __ibm128 with -msoft-float (PR target/105334)
+
+This patch allows __ibm128 to be used on systems with software floating point
+enabled.  Previously, we required hardware floating point to be enabled to use
+__ibm128 keyword and the __ibm128 built-in functions.  This patch fixes PR
+target/105334.
+
+2022-09-09   Michael Meissner  <meissner@linux.ibm.com>
+
+gcc/
+
+	PR target/105334
+	* config/rs6000/rs6000.cc (init_float128_ibm): Do not require hardware
+	floating point for the IBM 128-bit floating point comparison functions.
+	* config/rs6000/rs6000.h (FLOAT128_IBM_P): Do not require hardware
+	floating point to enable recognizing IBM 128-bit floating point modes.
+
+==================== work100, patch #2
+
+Allow __ibm128 even if IEEE 128-bit floating point is not supported.
+
+This patch allows the use of the __ibm128 keyword on non-VSX systems.
+Originally, the __ibm128 keyword was only enabled when the IEEE 128-bit
+floating point is enabled.  Sometime back in the GCC 12 development period,
+Segher asked that the __ibm128 keyword be allowed in older systems that don't
+support IEEE 128-bit.  But at the time, stage 1 had closed for GCC 12, so I
+deferred doing this change until GCC 13.  This patch allows __ibm128 to be used
+if either IEEE 128-bit is enabled or long double used the IBM 128-bit format.
+
+2022-09-09   Michael Meissner  <meissner@linux.ibm.com>
+
+gcc/
+
+	* config/rs6000/rs6000-builtins.cc (rs6000_init_builtins): Enable using
+	the__ibm128 keyword on systems that either use the 128-bit IBM long
+	double format for long double or support IEEE 128-bit.
+	* config/rs6000/rs6000.cc (rs6000_init_libfuncs): Create IBM 128-bit
+	floating point support functions on systems that support the __ibm128
+	keyword.
+	(rs6000_scalar_mode_supported_p): Likewise.
+	* config/rs6000/rs6000.h (TARGET_IBM128): New macro.
+	* config/rs6000/rs6000.md (@extenddf<mode>2_fprs): Allow IFmode to be
+	converted even if long double is not 128-bits.
+	(extenddf<mode>2_vsx): Likewise.
+	(extendiftf2):Allow conversion on systems that support the __ibm128
+	keyword.
+	(extendtfif2): Likewise.
+	(trunciftf2): Likewise.
+	(trunctfif2): Likewise.
+
+==================== work100, patch #1
+
+Update float 128-bit conversions.
+
+This patch is a rewrite of the patch submitted on August 18th:
+
+| https://gcc.gnu.org/pipermail/gcc-patches/2022-August/599988.html
+
+This patch reworks the conversions between 128-bit binary floating point types.
+Previously, we would call rs6000_expand_float128_convert to do all conversions.
+Now, we only define the conversions between the same representation that turn
+into a NOP.  The appropriate extend or truncate insn is generated, and after
+register allocation, it is converted to a move.
+
+This patch also fixes two places where we want to override the external name
+for the conversion function, and the wrong optab was used.  Previously,
+rs6000_expand_float128_convert would handle the move or generate the call as
+needed.  Now, it lets the machine independent code generate the call.  But if
+we use the machine independent code to generate the call, we need to update the
+name for two optabs where a truncate would be used in terms of converting
+between the modes.  This patch updates those two optabs.
+
+While I know you feel the whole area needs to be rewritten, I would think it is
+better to make things work incrementally rather than waiting for some grand
+rewrite (that may or may not occur).
+
+With the current sources, we don't yet need this patch.  But we will need this
+patch when a future patch is submitted that will change the internal __float128
+type to use the _Float128 type when long double is IEEE 128-bit.  I'm trying to
+break out the smaller patches that each can stand alone, without having a
+single larger patch.  This future patch will fix various testsuite issues with
+signalling NaNs when long double is IEEE 128-bit.
+
+I tested this patch on:
+
+    1)	LE Power10 using --with-cpu=power10 --with-long-double-format=ieee
+    2)	LE Power10 using --with-cpu=power9  --with-long-double-format=ibm
+    3)	LE Power10 using --with-cpu=power8  --with-long-double-format=ibm
+    4)	LE Power10 using --with-cpu=power10 --with-long-double-format=ibm
+    5)	LE Power9  using --with-cpu=power9  --with-long-double-format=ibm
+    6)	BE Power7  using --with-cpu=power7  --with-long-double-format=ibm
+
+There were no regressions in the bootstrap process or running the tests.  Can I
+check this patch into the trunk?
+
+2022-09-08   Michael Meissner  <meissner@linux.ibm.com>
+
+gcc/
+
+	* config/rs6000/rs6000.cc (init_float128_ieee): Use the correct
+	float_extend or float_truncate optab based on how the machine converts
+	between IEEE 128-bit and IBM 128-bit.
+	* config/rs6000/rs6000.md (IFKF): Delete.
+	(IFKF_reg): Delete.
+	(extendiftf2): Rewrite to be a move if IFmode and TFmode are both IBM
+	128-bit.  Do not run if TFmode is IEEE 128-bit.
+	(extendifkf2): Delete.
+	(extendtfkf2): Delete.
+	(extendtfif2): Delete.
+	(trunciftf2): Delete.
+	(truncifkf2): Delete.
+	(trunckftf2): Delete.
+	(extendkftf2): Implement conversion of IEEE 128-bit types as a move.
+	(trunctfif2): Delete.
+	(trunctfkf2): Implement conversion of IEEE 128-bit types as a move.
+	(extend<mode>tf2_internal): Delete.
+	(extendtf<mode>2_internal): Delete.
+
+==================== work100, branch creation
+
 2022-09-08   Michael Meissner  <meissner@linux.ibm.com>
 
 	Clone branch

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-09-09 21:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-09 21:07 [gcc(refs/users/meissner/heads/work100)] Update ChangeLog.meissner Michael Meissner
  -- strict thread matches above, loose matches on Subject: below --
2022-09-09 18:34 Michael Meissner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).