public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r13-2760] Clear unused flags in frange for undefined ranges.
@ 2022-09-21 11:29 Aldy Hernandez
0 siblings, 0 replies; only message in thread
From: Aldy Hernandez @ 2022-09-21 11:29 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:324fa420b66bc084dd5b20644c6ee7b35be90c00
commit r13-2760-g324fa420b66bc084dd5b20644c6ee7b35be90c00
Author: Aldy Hernandez <aldyh@redhat.com>
Date: Wed Sep 21 09:49:14 2022 +0200
Clear unused flags in frange for undefined ranges.
gcc/ChangeLog:
* value-range.cc (frange::combine_zeros): Call set_undefined.
(frange::intersect_nans): Same.
(frange::intersect): Same.
(frange::verify_range): Undefined ranges do not have a type.
* value-range.h (frange::set_undefined): Clear NAN flags and type.
Diff:
---
gcc/value-range.cc | 8 ++++----
gcc/value-range.h | 4 ++++
2 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/gcc/value-range.cc b/gcc/value-range.cc
index dc42b6d3120..505eb9211a7 100644
--- a/gcc/value-range.cc
+++ b/gcc/value-range.cc
@@ -422,7 +422,7 @@ frange::combine_zeros (const frange &r, bool union_p)
if (maybe_isnan ())
m_kind = VR_NAN;
else
- m_kind = VR_UNDEFINED;
+ set_undefined ();
changed = true;
}
return changed;
@@ -506,7 +506,7 @@ frange::intersect_nans (const frange &r)
if (maybe_isnan ())
m_kind = VR_NAN;
else
- m_kind = VR_UNDEFINED;
+ set_undefined ();
if (flag_checking)
verify_range ();
return true;
@@ -558,7 +558,7 @@ frange::intersect (const vrange &v)
if (maybe_isnan ())
m_kind = VR_NAN;
else
- m_kind = VR_UNDEFINED;
+ set_undefined ();
if (flag_checking)
verify_range ();
return true;
@@ -696,7 +696,7 @@ frange::verify_range ()
switch (m_kind)
{
case VR_UNDEFINED:
- // m_type is ignored.
+ gcc_checking_assert (!m_type);
return;
case VR_VARYING:
gcc_checking_assert (m_type);
diff --git a/gcc/value-range.h b/gcc/value-range.h
index 325ed08f290..3668b331187 100644
--- a/gcc/value-range.h
+++ b/gcc/value-range.h
@@ -1083,6 +1083,10 @@ inline void
frange::set_undefined ()
{
m_kind = VR_UNDEFINED;
+ m_type = NULL;
+ m_pos_nan = false;
+ m_neg_nan = false;
+ // m_min and m_min are unitialized as they are REAL_VALUE_TYPE ??.
if (flag_checking)
verify_range ();
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-09-21 11:29 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-21 11:29 [gcc r13-2760] Clear unused flags in frange for undefined ranges Aldy Hernandez
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).