public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc/devel/rust/master] Static Items must be const evaluated
@ 2022-09-23  6:51 Thomas Schwinge
  0 siblings, 0 replies; only message in thread
From: Thomas Schwinge @ 2022-09-23  6:51 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:53f4a8601c1db2068390dce7012c16b383864740

commit 53f4a8601c1db2068390dce7012c16b383864740
Author: Philip Herron <philip.herron@embecosm.com>
Date:   Sat Sep 17 10:04:49 2022 +0100

    Static Items must be const evaluated
    
    Statics like constants need to have a singular value they are not functions
    to be lazy evaluated. So to evaluate a block expr we can just reuse our
    const code to resolve this to a singular value.

Diff:
---
 gcc/rust/backend/rust-compile-item.cc | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/gcc/rust/backend/rust-compile-item.cc b/gcc/rust/backend/rust-compile-item.cc
index 96c4e7fcf61..8ba17c9ff0d 100644
--- a/gcc/rust/backend/rust-compile-item.cc
+++ b/gcc/rust/backend/rust-compile-item.cc
@@ -43,13 +43,18 @@ CompileItem::visit (HIR::StaticItem &var)
   rust_assert (ok);
 
   tree type = TyTyResolveCompile::compile (ctx, resolved_type);
-  tree value = CompileExpr::Compile (var.get_expr (), ctx);
 
   const Resolver::CanonicalPath *canonical_path = nullptr;
   ok = ctx->get_mappings ()->lookup_canonical_path (
     var.get_mappings ().get_nodeid (), &canonical_path);
   rust_assert (ok);
 
+  HIR::Expr *const_value_expr = var.get_expr ();
+  ctx->push_const_context ();
+  tree value = compile_constant_item (ctx, resolved_type, canonical_path,
+				      const_value_expr, var.get_locus ());
+  ctx->pop_const_context ();
+
   std::string name = canonical_path->get ();
   std::string asm_name = ctx->mangle_item (resolved_type, *canonical_path);

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-09-23  6:51 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-23  6:51 [gcc/devel/rust/master] Static Items must be const evaluated Thomas Schwinge

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).