public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r13-2880] Optimize [0 = x & MASK] in range-ops.
@ 2022-09-26 17:25 Aldy Hernandez
0 siblings, 0 replies; only message in thread
From: Aldy Hernandez @ 2022-09-26 17:25 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:5e77d4082fa845f1182641a93cfbae71984244d2
commit r13-2880-g5e77d4082fa845f1182641a93cfbae71984244d2
Author: Aldy Hernandez <aldyh@redhat.com>
Date: Fri Sep 23 19:47:19 2022 +0200
Optimize [0 = x & MASK] in range-ops.
For [0 = x & MASK], we can determine that x is ~MASK. This is
something we're picking up in DOM thanks to maybe_set_nonzero_bits,
but is something we should handle natively.
This is a good example of how much easier to maintain the range-ops
entries are versus the ad-hoc pattern matching stuff we had to do
before. For the curious, compare the changes to range-op here,
versus maybe_set_nonzero_bits.
I'm leaving the call to maybe_set_nonzero_bits until I can properly
audit it to make sure we're catching it all in range-ops. It won't
hurt, since both set_range_info() and set_nonzero_bits() are
intersect operations, so we'll never lose information if we do both.
PR tree-optimization/107009
gcc/ChangeLog:
* range-op.cc (operator_bitwise_and::op1_range): Optimize 0 = x & MASK.
(range_op_bitwise_and_tests): New test.
Diff:
---
gcc/range-op.cc | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/gcc/range-op.cc b/gcc/range-op.cc
index 072ebd32109..fc930f4d613 100644
--- a/gcc/range-op.cc
+++ b/gcc/range-op.cc
@@ -2951,6 +2951,15 @@ operator_bitwise_and::op1_range (irange &r, tree type,
}
if (r.undefined_p ())
set_nonzero_range_from_mask (r, type, lhs);
+
+ // For 0 = op1 & MASK, op1 is ~MASK.
+ if (lhs.zero_p () && op2.singleton_p ())
+ {
+ wide_int nz = wi::bit_not (op2.get_nonzero_bits ());
+ int_range<2> tmp (type);
+ tmp.set_nonzero_bits (nz);
+ r.intersect (tmp);
+ }
return true;
}
@@ -4612,6 +4621,15 @@ range_op_bitwise_and_tests ()
op_bitwise_and.op1_range (res, integer_type_node, i1, i2);
ASSERT_TRUE (res == int_range<1> (integer_type_node));
+ // For 0 = x & MASK, x is ~MASK.
+ {
+ int_range<2> zero (integer_zero_node, integer_zero_node);
+ int_range<2> mask = int_range<2> (INT (7), INT (7));
+ op_bitwise_and.op1_range (res, integer_type_node, zero, mask);
+ wide_int inv = wi::shwi (~7U, TYPE_PRECISION (integer_type_node));
+ ASSERT_TRUE (res.get_nonzero_bits () == inv);
+ }
+
// (NONZERO | X) is nonzero.
i1.set_nonzero (integer_type_node);
i2.set_varying (integer_type_node);
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-09-26 17:25 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-26 17:25 [gcc r13-2880] Optimize [0 = x & MASK] in range-ops Aldy Hernandez
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).