public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Lewis Hyatt <lhyatt@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r13-3051] diagnostics: Add test for fixed _Pragma location issue [PR91669]
Date: Tue,  4 Oct 2022 01:29:26 +0000 (GMT)	[thread overview]
Message-ID: <20221004012927.138253858D38@sourceware.org> (raw)

https://gcc.gnu.org/g:70e3f71a279856eabf99bbc92c0345c3ad20b615

commit r13-3051-g70e3f71a279856eabf99bbc92c0345c3ad20b615
Author: Lewis Hyatt <lhyatt@gmail.com>
Date:   Sat Oct 1 12:05:13 2022 -0400

    diagnostics: Add test for fixed _Pragma location issue [PR91669]
    
    This PR related to _Pragma locations and diagnostic pragmas was fixed by a
    combination of r10-325 and r13-1596. Add missing test coverage.
    
    gcc/testsuite/ChangeLog:
    
            PR c/91669
            * c-c++-common/pr91669.c: New test.

Diff:
---
 gcc/testsuite/c-c++-common/pr91669.c | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gcc/testsuite/c-c++-common/pr91669.c b/gcc/testsuite/c-c++-common/pr91669.c
new file mode 100644
index 00000000000..1070751ed2e
--- /dev/null
+++ b/gcc/testsuite/c-c++-common/pr91669.c
@@ -0,0 +1,28 @@
+/* { dg-do compile } */
+/* { dg-additional-options "-Wreturn-type" } */
+
+/* The location of the right brace within the macro expansion can be an adhoc
+   location, because the frontend attached custom data to it.  In order for the
+   diagnostic pragma to correctly understand that the diagnostic pop occurs
+   after the function and not before, linemap_location_before_p needs to handle
+   adhoc locations within a macro map, which was broken until fixed by r10-325.
+   Verify that we get it right, both when the brace is a macro token and when it
+   is part of the macro expansion.  */
+
+#define ENDFUNC1 \
+  _Pragma("GCC diagnostic push") \
+  _Pragma("GCC diagnostic ignored \"-Wreturn-type\"") \
+  } /* { dg-bogus {-Wreturn-type} } */ \
+  _Pragma("GCC diagnostic pop")
+
+int f1 () {
+ENDFUNC1 /* { dg-bogus {in expansion of macro 'ENDFUNC1' } } */
+
+#define ENDFUNC2(term) \
+  _Pragma("GCC diagnostic push") \
+  _Pragma("GCC diagnostic ignored \"-Wreturn-type\"") \
+  term /* { dg-bogus {in definition of macro 'ENDFUNC2'} } */ \
+  _Pragma("GCC diagnostic pop")
+
+int f2 () {
+ENDFUNC2(}) /* { dg-bogus {-Wreturn-type} } */

                 reply	other threads:[~2022-10-04  1:29 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221004012927.138253858D38@sourceware.org \
    --to=lhyatt@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).