public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r13-3201] Don't ICE running selftests if errors were raised [PR99723]
@ 2022-10-10 13:22 Andrea Corallo
  0 siblings, 0 replies; only message in thread
From: Andrea Corallo @ 2022-10-10 13:22 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:248c8aeebc49aae3fd96bd587367d12e7c8b3c3a

commit r13-3201-g248c8aeebc49aae3fd96bd587367d12e7c8b3c3a
Author: Andrea Corallo <andrea.corallo@arm.com>
Date:   Tue Sep 27 16:20:28 2022 +0200

    Don't ICE running selftests if errors were raised [PR99723]
    
    Hi all
    
    this is to address PR 99723.
    
    In the PR GCC crashes as the initialization of common trees is not
    performed as no compilation is happening, this is because we raise an
    error earlier while processing the arch flags.
    
    This patch changes the code to execute selftests only if no errors
    where raised before.
    
    Bootstrapped on aarch64, okay for trunk?
    
    Best Regards
    
      Andrea
    
    2022-09-27  Andrea Corallo  <andrea.corallo@arm.com>
    
            PR other/99723
            * toplev.cc (toplev::main): Don't run self tests in case of
            previous error.

Diff:
---
 gcc/toplev.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/toplev.cc b/gcc/toplev.cc
index 924871fa9a8..b53a78bbaf1 100644
--- a/gcc/toplev.cc
+++ b/gcc/toplev.cc
@@ -2276,7 +2276,7 @@ toplev::main (int argc, char **argv)
 	start_timevars ();
       do_compile (no_backend);
 
-      if (flag_self_test)
+      if (flag_self_test && !seen_error ())
 	{
 	  if (no_backend)
 	    error_at (UNKNOWN_LOCATION, "self-tests incompatible with %<-E%>");

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-10-10 13:22 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-10 13:22 [gcc r13-3201] Don't ICE running selftests if errors were raised [PR99723] Andrea Corallo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).