public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r13-3205] compiler: treat S("") as a string constant
@ 2022-10-10 21:46 Ian Lance Taylor
  0 siblings, 0 replies; only message in thread
From: Ian Lance Taylor @ 2022-10-10 21:46 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:29b0fe393859729215b0db5d28f2faea30c6ec32

commit r13-3205-g29b0fe393859729215b0db5d28f2faea30c6ec32
Author: Ian Lance Taylor <iant@golang.org>
Date:   Sun Oct 9 12:52:17 2022 -0700

    compiler: treat S("") as a string constant
    
    The compiler neglected to notice that a conversion from a string
    constant to a string type was a valid string constant.
    
    No test case because this only caused a compiler failure when compiling
    without optimization, which is not the normal case, and is not a case
    that we test.
    
    Fixes golang/go#56113
    
    Reviewed-on: https://go-review.googlesource.com/c/gofrontend/+/441555

Diff:
---
 gcc/go/gofrontend/MERGE          | 2 +-
 gcc/go/gofrontend/expressions.cc | 3 +++
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/gcc/go/gofrontend/MERGE b/gcc/go/gofrontend/MERGE
index 1c2466090f1..5b95b38a541 100644
--- a/gcc/go/gofrontend/MERGE
+++ b/gcc/go/gofrontend/MERGE
@@ -1,4 +1,4 @@
-164f2aeb1deec4c11e55b8bfb152ff7ff4c1dd4c
+6c188108858e3ae8c8ea8e4cc55427d8cf01bbc8
 
 The first line of this file holds the git revision number of the last
 merge done from the gofrontend repository.
diff --git a/gcc/go/gofrontend/expressions.cc b/gcc/go/gofrontend/expressions.cc
index 247ae1bba34..71838b14629 100644
--- a/gcc/go/gofrontend/expressions.cc
+++ b/gcc/go/gofrontend/expressions.cc
@@ -4092,6 +4092,9 @@ Type_conversion_expression::do_numeric_constant_value(
 bool
 Type_conversion_expression::do_string_constant_value(std::string* val) const
 {
+  if (this->type_->is_string_type() && this->expr_->type()->is_string_type())
+    return this->expr_->string_constant_value(val);
+
   if (this->type_->is_string_type()
       && this->expr_->type()->integer_type() != NULL)
     {

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-10-10 21:46 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-10 21:46 [gcc r13-3205] compiler: treat S("") as a string constant Ian Lance Taylor

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).