public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r13-3244] Disable tree to bool conversion in frange::update_nan.
@ 2022-10-12 6:51 Aldy Hernandez
0 siblings, 0 replies; only message in thread
From: Aldy Hernandez @ 2022-10-12 6:51 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:6ce0823721d476cabb2007fecc12c07202325e17
commit r13-3244-g6ce0823721d476cabb2007fecc12c07202325e17
Author: Aldy Hernandez <aldyh@redhat.com>
Date: Tue Oct 11 19:20:47 2022 +0200
Disable tree to bool conversion in frange::update_nan.
We have a set_nan(type) method which can be confused with
update_nan(bool) because of the silent conversion of pointers to bool.
Currently, if you call update_nan(tree), you'll set the possibility of
NAN with a sign of true if tree is non-null. This is prone to error
and this patch disallows this behavior.
gcc/ChangeLog:
* value-range.cc (frange::set_nonnegative): Pass bool to
update_nan.
* value-range.h: Disallow conversion to bool in update_nan().
Diff:
---
gcc/value-range.cc | 2 +-
gcc/value-range.h | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/gcc/value-range.cc b/gcc/value-range.cc
index e07d2aa9a5b..26a2b782e2c 100644
--- a/gcc/value-range.cc
+++ b/gcc/value-range.cc
@@ -779,7 +779,7 @@ frange::set_nonnegative (tree type)
// Set +NAN as the only possibility.
if (HONOR_NANS (type))
- update_nan (/*sign=*/0);
+ update_nan (/*sign=*/false);
}
// Here we copy between any two irange's. The ranges can be legacy or
diff --git a/gcc/value-range.h b/gcc/value-range.h
index 9d630e40f78..cb5e9d0522c 100644
--- a/gcc/value-range.h
+++ b/gcc/value-range.h
@@ -317,6 +317,7 @@ public:
const REAL_VALUE_TYPE &upper_bound () const;
void update_nan ();
void update_nan (bool sign);
+ void update_nan (tree) = delete; // Disallow silent conversion to bool.
void clear_nan ();
// fpclassify like API
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-10-12 6:51 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-12 6:51 [gcc r13-3244] Disable tree to bool conversion in frange::update_nan Aldy Hernandez
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).