public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r13-3285] analyzer: fix ICE introduced in r13-3168 [PR107210]
@ 2022-10-13 20:06 David Malcolm
  0 siblings, 0 replies; only message in thread
From: David Malcolm @ 2022-10-13 20:06 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:99da523359e9333555585484eb3b8f854a98f1b4

commit r13-3285-g99da523359e9333555585484eb3b8f854a98f1b4
Author: David Malcolm <dmalcolm@redhat.com>
Date:   Thu Oct 13 16:05:35 2022 -0400

    analyzer: fix ICE introduced in r13-3168 [PR107210]
    
    gcc/analyzer/ChangeLog:
            PR analyzer/107210
            * svalue.cc (constant_svalue::maybe_fold_bits_within): Only
            attempt to extract individual bits when tree_fits_uhwi_p.
    
    gcc/testsuite/ChangeLog:
            PR analyzer/107210
            * gfortran.dg/analyzer/pr107210.f90: New test.
    
    Signed-off-by: David Malcolm <dmalcolm@redhat.com>

Diff:
---
 gcc/analyzer/svalue.cc                          |  3 ++-
 gcc/testsuite/gfortran.dg/analyzer/pr107210.f90 | 16 ++++++++++++++++
 2 files changed, 18 insertions(+), 1 deletion(-)

diff --git a/gcc/analyzer/svalue.cc b/gcc/analyzer/svalue.cc
index a0838c0f588..4b00a81b31d 100644
--- a/gcc/analyzer/svalue.cc
+++ b/gcc/analyzer/svalue.cc
@@ -884,7 +884,8 @@ constant_svalue::maybe_fold_bits_within (tree type,
   if (bits.m_size_in_bits == 1
       && TREE_CODE (m_cst_expr) == INTEGER_CST
       && type
-      && INTEGRAL_TYPE_P (type))
+      && INTEGRAL_TYPE_P (type)
+      && tree_fits_uhwi_p (m_cst_expr))
     {
       unsigned HOST_WIDE_INT bit = bits.m_start_bit_offset.to_uhwi ();
       unsigned HOST_WIDE_INT mask = (1 << bit);
diff --git a/gcc/testsuite/gfortran.dg/analyzer/pr107210.f90 b/gcc/testsuite/gfortran.dg/analyzer/pr107210.f90
new file mode 100644
index 00000000000..6132db48817
--- /dev/null
+++ b/gcc/testsuite/gfortran.dg/analyzer/pr107210.f90
@@ -0,0 +1,16 @@
+! { dg-additional-options "-O1" }
+
+subroutine check_int (j)
+  INTEGER(4) :: i, ia(5), ib(5,4), ip, ipa(:)
+  target :: ib
+  POINTER :: ip, ipa
+  logical :: l(5)
+
+  ipa=>ib(2:3,1)
+
+  l = (/ sizeof(i) == 4, sizeof(ia) == 20, sizeof(ib) == 80, &
+       sizeof(ip) == 4, sizeof(ipa) == 8 /)
+
+  if (any(.not.l)) STOP 4
+
+end subroutine check_int

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-10-13 20:06 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-13 20:06 [gcc r13-3285] analyzer: fix ICE introduced in r13-3168 [PR107210] David Malcolm

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).