public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r12-8845] rs6000: Fix condition of define_expand vec_shr_<mode> [PR100645]
@ 2022-10-19 9:05 Kewen Lin
0 siblings, 0 replies; only message in thread
From: Kewen Lin @ 2022-10-19 9:05 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:6db4ba9750ffd65c80995425db0d5f1020a04b28
commit r12-8845-g6db4ba9750ffd65c80995425db0d5f1020a04b28
Author: Kewen Lin <linkw@linux.ibm.com>
Date: Sun Sep 25 22:01:50 2022 -0500
rs6000: Fix condition of define_expand vec_shr_<mode> [PR100645]
PR100645 exposes one latent bug in define_expand vec_shr_<mode>
that the current condition TARGET_ALTIVEC is too loose. The
mode iterator VEC_L contains a few modes, they are not always
supported as vector mode, VECTOR_UNIT_ALTIVEC_OR_VSX_P should
be used like some other VEC_L usages.
PR target/100645
gcc/ChangeLog:
* config/rs6000/vector.md (vec_shr_<mode>): Replace condition
TARGET_ALTIVEC with VECTOR_UNIT_ALTIVEC_OR_VSX_P.
gcc/testsuite/ChangeLog:
* gcc.target/powerpc/pr100645.c: New test.
(cherry picked from commit bfad7069b74c97000b698191c1945f07a6192db5)
Diff:
---
gcc/config/rs6000/vector.md | 2 +-
gcc/testsuite/gcc.target/powerpc/pr100645.c | 13 +++++++++++++
2 files changed, 14 insertions(+), 1 deletion(-)
diff --git a/gcc/config/rs6000/vector.md b/gcc/config/rs6000/vector.md
index 4d0797c48f8..9436f002f08 100644
--- a/gcc/config/rs6000/vector.md
+++ b/gcc/config/rs6000/vector.md
@@ -1535,7 +1535,7 @@
[(match_operand:VEC_L 0 "vlogical_operand")
(match_operand:VEC_L 1 "vlogical_operand")
(match_operand:QI 2 "reg_or_short_operand")]
- "TARGET_ALTIVEC"
+ "VECTOR_UNIT_ALTIVEC_OR_VSX_P (<MODE>mode)"
{
rtx bitshift = operands[2];
rtx shift;
diff --git a/gcc/testsuite/gcc.target/powerpc/pr100645.c b/gcc/testsuite/gcc.target/powerpc/pr100645.c
new file mode 100644
index 00000000000..c4e92cc8052
--- /dev/null
+++ b/gcc/testsuite/gcc.target/powerpc/pr100645.c
@@ -0,0 +1,13 @@
+/* { dg-require-effective-target powerpc_altivec_ok } */
+/* { dg-options "-mdejagnu-cpu=power6 -maltivec" } */
+
+/* This used to ICE. */
+
+typedef long long v2di __attribute__ ((vector_size (16)));
+
+v2di
+foo_v2di_l (v2di x)
+{
+ return __builtin_shuffle ((v2di){0, 0}, x, (v2di){3, 0});
+}
+
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-10-19 9:05 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-19 9:05 [gcc r12-8845] rs6000: Fix condition of define_expand vec_shr_<mode> [PR100645] Kewen Lin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).