[gcc r13-4010] ada: Adjust locations in aspects on generic formal subprograms

[gcc r13-4010] ada: Adjust locations in aspects on generic formal subprograms

[Marc Poulhi?s]

https://gcc.gnu.org/g:28e5c45bd519aa363cba1eec4d215b173c360cab

commit r13-4010-g28e5c45bd519aa363cba1eec4d215b173c360cab
Author: Piotr Trojanek <trojanek@adacore.com>
Date:   Fri Oct 28 22:15:53 2022 +0200

    ada: Adjust locations in aspects on generic formal subprograms
    
    When instantiating a generic that has formal subprogram parameter with
    contracts, e.g.:
    
      generic
        with procedure P with Pre => ..., Post => ...;
      ...
    
    we create a wrapper that executes Pre/Post contracts before/after
    calling the actual subprogram. Errors emitted for these contracts
    will now have locations of the instance and not just of the generic.
    
    gcc/ada/
    
            * sem_ch12.adb (Build_Subprogram_Wrappers): Adjust slocs of the
            copied aspects, just like we do in Build_Class_Wide_Expression for
            inherited class-wide contracts.

Diff:
---
 gcc/ada/sem_ch12.adb | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/gcc/ada/sem_ch12.adb b/gcc/ada/sem_ch12.adb
index 03ce5d51a03..72c2eef7061 100644
--- a/gcc/ada/sem_ch12.adb
+++ b/gcc/ada/sem_ch12.adb
@@ -1203,12 +1203,31 @@ package body Sem_Ch12 is
       -------------------------------
 
       procedure Build_Subprogram_Wrappers is
+         function Adjust_Aspect_Sloc (N : Node_Id) return Traverse_Result;
+         --  Adjust sloc so that errors located at N will be reported with
+         --  information about the instance and not just about the generic.
+
+         ------------------------
+         -- Adjust_Aspect_Sloc --
+         ------------------------
+
+         function Adjust_Aspect_Sloc (N : Node_Id) return Traverse_Result is
+         begin
+            Adjust_Instantiation_Sloc (N, S_Adjustment);
+            return OK;
+         end Adjust_Aspect_Sloc;
+
+         procedure Adjust_Aspect_Slocs is new
+           Traverse_Proc (Adjust_Aspect_Sloc);
+
          Formal : constant Entity_Id :=
            Defining_Unit_Name (Specification (Analyzed_Formal));
          Aspect_Spec : Node_Id;
          Decl_Node   : Node_Id;
          Actual_Name : Node_Id;
 
+      --  Start of processing for Build_Subprogram_Wrappers
+
       begin
          --  Create declaration for wrapper subprogram
          --  The actual can be overloaded, in which case it will be
@@ -1247,6 +1266,7 @@ package body Sem_Ch12 is
 
          Aspect_Spec := First (Aspect_Specifications (Decl_Node));
          while Present (Aspect_Spec) loop
+            Adjust_Aspect_Slocs (Aspect_Spec);
             Set_Analyzed (Aspect_Spec, False);
             Next (Aspect_Spec);
          end loop;