[gcc/devel/rust/master] Merge #1635

[gcc/devel/rust/master] Merge #1635

[Thomas Schwinge]

https://gcc.gnu.org/g:4c565999541c60ac5d1b5af618963e701b384fdd

commit 4c565999541c60ac5d1b5af618963e701b384fdd
Merge: 815a57351a3 9657c328d0c
Author: bors[bot] <26634292+bors[bot]@users.noreply.github.com>
Date:   Tue Nov 15 16:16:01 2022 +0000

    Merge #1635
    
    1635: rust: Remove unused variables and fix dangling references r=CohenArthur a=CohenArthur
    
    This should make the bootstrap build green again.
    
    This commit contains some aggressive refactoring which either removes unused arguments altogether or removes the argument name in some cases where it might get used later on or cannot change due to implementing a virtual method or something like that.
    
    Co-authored-by: Arthur Cohen <arthur.cohen@embecosm.com>

Diff:

 gcc/rust/ast/rust-ast-dump.cc                      | 174 +++++-----
 gcc/rust/backend/rust-compile-base.cc              |   4 +-
 gcc/rust/backend/rust-compile-base.h               |   6 +-
 gcc/rust/backend/rust-compile-expr.cc              |  61 ++--
 gcc/rust/backend/rust-compile-expr.h               |  13 +-
 gcc/rust/backend/rust-compile-fnparam.cc           |   2 +-
 gcc/rust/backend/rust-compile-implitem.h           |   2 +-
 gcc/rust/backend/rust-compile-intrinsic.cc         |   2 +-
 gcc/rust/backend/rust-compile-pattern.cc           |   2 +-
 gcc/rust/backend/rust-compile-resolve-path.cc      |  12 +-
 gcc/rust/backend/rust-compile-resolve-path.h       |   3 +-
 gcc/rust/backend/rust-compile-type.cc              |   8 +-
 gcc/rust/backend/rust-compile.cc                   |  12 +-
 gcc/rust/backend/rust-constexpr.cc                 |   6 +-
 gcc/rust/backend/rust-tree.cc                      |  38 +--
 .../checks/errors/privacy/rust-privacy-reporter.cc |  58 ++--
 .../checks/errors/privacy/rust-reachability.cc     |   4 +-
 .../errors/privacy/rust-visibility-resolver.cc     |   8 +-
 gcc/rust/checks/errors/rust-const-checker.cc       | 132 ++++----
 gcc/rust/checks/errors/rust-unsafe-checker.cc      | 142 ++++-----
 gcc/rust/checks/lints/rust-lint-marklive.cc        |   2 +-
 gcc/rust/checks/lints/rust-lint-unused-var.cc      |   2 +-
 gcc/rust/expand/rust-macro-builtins.cc             |  20 +-
 gcc/rust/hir/rust-ast-lower-base.cc                | 352 ++++++++++-----------
 gcc/rust/hir/rust-hir-dump.cc                      |   4 +-
 gcc/rust/hir/tree/rust-hir-full-test.cc            |   2 +-
 gcc/rust/lex/rust-lex.cc                           |   6 +-
 gcc/rust/lex/rust-lex.h                            |   2 +-
 gcc/rust/metadata/rust-export-metadata.cc          |  24 +-
 gcc/rust/resolve/rust-ast-resolve-expr.cc          |   6 +-
 gcc/rust/resolve/rust-ast-resolve-type.cc          |   6 +-
 gcc/rust/resolve/rust-ast-verify-assignee.h        |   8 +-
 gcc/rust/resolve/rust-early-name-resolver.cc       | 120 +++----
 gcc/rust/typecheck/rust-hir-dot-operator.cc        |   4 +-
 .../typecheck/rust-hir-inherent-impl-overlap.h     |   7 +-
 gcc/rust/typecheck/rust-hir-path-probe.cc          |   2 +-
 gcc/rust/typecheck/rust-hir-trait-ref.h            |   6 +-
 gcc/rust/typecheck/rust-hir-trait-resolve.cc       |   2 +-
 gcc/rust/typecheck/rust-hir-type-check-expr.cc     |   2 +-
 gcc/rust/typecheck/rust-hir-type-check-expr.h      |  32 +-
 gcc/rust/typecheck/rust-hir-type-check-item.h      |   4 +-
 gcc/rust/typecheck/rust-hir-type-check-path.cc     |   2 +-
 gcc/rust/typecheck/rust-hir-type-check-pattern.cc  |  10 +-
 gcc/rust/typecheck/rust-hir-type-check-stmt.h      |   9 +-
 gcc/rust/typecheck/rust-hir-type-check-type.cc     |  10 +-
 gcc/rust/typecheck/rust-hir-type-check-type.h      |  10 +-
 gcc/rust/typecheck/rust-hir-type-check.cc          |   3 +-
 gcc/rust/typecheck/rust-tyty-bounds.cc             |   2 +-
 gcc/rust/typecheck/rust-tyty-call.h                |   2 +-
 gcc/rust/typecheck/rust-tyty-cmp.h                 |  16 +-
 gcc/rust/typecheck/rust-tyty-rules.h               |  48 +--
 gcc/rust/typecheck/rust-tyty.cc                    |   7 +-
 gcc/rust/util/rust-attributes.cc                   | 312 +++++++++---------
 53 files changed, 840 insertions(+), 893 deletions(-)