public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r13-4260] c++: Fix up -fcontract* options
@ 2022-11-23  8:30 Jakub Jelinek
  0 siblings, 0 replies; only message in thread
From: Jakub Jelinek @ 2022-11-23  8:30 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:e1b503d7068cbaf4be938c02eb6686ea5a716fee

commit r13-4260-ge1b503d7068cbaf4be938c02eb6686ea5a716fee
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Wed Nov 23 09:29:04 2022 +0100

    c++: Fix up -fcontract* options
    
    I've noticed
    +FAIL: compiler driver --help=c++ option(s): "^ +-.*[^:.]\$" absent from output: "  -fcontract-build-level=[off|default|audit] Specify max contract level to generate runtime checks for"
    error, this is due to missing dot at the end of the description.
    
    The second part of the first hunk should fix that, but while at it,
    I find it weird that some options don't have RejectNegative, yet
    for options that accept an argument a negative option looks weird
    and isn't really handled.
    
    Though, shall we have those [on|off] options at all?
    Those are inconsistent with all other boolean options gcc has.
    Every other boolean option is -fwhatever for it being on
    and -fno-whatever for it being off, shouldn't the options be
    without arguments and accept negatives (-fcontract-assumption-mode
    vs. -fno-contract-assumption-mode etc.)?
    
    2022-11-23  Jakub Jelinek  <jakub@redhat.com>
    
            * c.opt (fcontract-assumption-mode=, fcontract-continuation-mode=,
            fcontract-role=, fcontract-semantic=): Add RejectNegative.
            (fcontract-build-level=): Terminate description with dot.

Diff:
---
 gcc/c-family/c.opt | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/gcc/c-family/c.opt b/gcc/c-family/c.opt
index 90088804e64..4b0539132c6 100644
--- a/gcc/c-family/c.opt
+++ b/gcc/c-family/c.opt
@@ -1692,12 +1692,12 @@ EnumValue
 Enum(on_off) String(on) Value(1)
 
 fcontract-assumption-mode=
-C++ Joined
+C++ Joined RejectNegative
 -fcontract-assumption-mode=[on|off]	Enable or disable treating axiom level contracts as assumptions (default on).
 
 fcontract-build-level=
 C++ Joined RejectNegative
--fcontract-build-level=[off|default|audit]	Specify max contract level to generate runtime checks for
+-fcontract-build-level=[off|default|audit]	Specify max contract level to generate runtime checks for.
 
 fcontract-strict-declarations=
 C++ Var(flag_contract_strict_declarations) Enum(on_off) Joined Init(0) RejectNegative
@@ -1708,15 +1708,15 @@ C++ Var(flag_contract_mode) Enum(on_off) Joined Init(1) RejectNegative
 -fcontract-mode=[on|off]	Enable or disable all contract facilities (default on).
 
 fcontract-continuation-mode=
-C++ Joined
+C++ Joined RejectNegative
 -fcontract-continuation-mode=[on|off]	Enable or disable contract continuation mode (default off).
 
 fcontract-role=
-C++ Joined
+C++ Joined RejectNegative
 -fcontract-role=<name>:<semantics>	Specify the semantics for all levels in a role (default, review), or a custom contract role with given semantics (ex: opt:assume,assume,assume)
 
 fcontract-semantic=
-C++ Joined
+C++ Joined RejectNegative
 -fcontract-semantic=<level>:<semantic>	Specify the concrete semantics for level
 
 fcoroutines

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-11-23  8:30 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-23  8:30 [gcc r13-4260] c++: Fix up -fcontract* options Jakub Jelinek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).