public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r13-4266] doc: -Wdelete-non-virtual-dtor supersedes -Wnon-virtual-dtor
@ 2022-11-23 15:45 Jonathan Wakely
  0 siblings, 0 replies; only message in thread
From: Jonathan Wakely @ 2022-11-23 15:45 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:51f28e3aaf8b50554e7d356c8117399e63132323

commit r13-4266-g51f28e3aaf8b50554e7d356c8117399e63132323
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Wed Nov 23 10:01:06 2022 +0000

    doc: -Wdelete-non-virtual-dtor supersedes -Wnon-virtual-dtor
    
    The newer -Wdelete-non-virtual-dtor has no false positives and fewer
    bugs. There is very little reason to use -Wnon-virtual-dtor instead.
    
    gcc/ChangeLog:
    
            * doc/invoke.texi (C++ Dialect Options): Recommend using
            -Wdelete-non-virtual-dtor instead of -Wnon-virtual-dtor.

Diff:
---
 gcc/doc/invoke.texi | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi
index 330da6eb5d4..4899bd1ea4c 100644
--- a/gcc/doc/invoke.texi
+++ b/gcc/doc/invoke.texi
@@ -3986,6 +3986,9 @@ destructor itself or in an accessible polymorphic base class, in which
 case it is possible but unsafe to delete an instance of a derived
 class through a pointer to the class itself or base class.  This
 warning is automatically enabled if @option{-Weffc++} is specified.
+The @option{-Wdelete-non-virtual-dtor} option (enabled by @option{-Wall})
+should be preferred because it warns about the unsafe cases without false
+positives.
 
 @item -Wregister @r{(C++ and Objective-C++ only)}
 @opindex Wregister

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-11-23 15:45 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-23 15:45 [gcc r13-4266] doc: -Wdelete-non-virtual-dtor supersedes -Wnon-virtual-dtor Jonathan Wakely

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).