public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r13-4459] match.pd: rewrite select to branchless expression
@ 2022-12-02  8:22 Richard Biener
  0 siblings, 0 replies; only message in thread
From: Richard Biener @ 2022-12-02  8:22 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:6508d5e5a1a8c08bebf83d258fad525eadc9f5d1

commit r13-4459-g6508d5e5a1a8c08bebf83d258fad525eadc9f5d1
Author: Michael Collison <collison@rivosinc.com>
Date:   Fri Dec 2 08:40:05 2022 +0100

    match.pd: rewrite select to branchless expression
    
    This patches transforms ((x & 0x1) == 0) ? y : z <op> y -into
    (-(typeof(y))(x & 0x1) & z) <op> y, where op is a '^' or a '|'. It also
    transforms (cond (and (x , 0x1) != 0), (z op y), y ) into (-(and (x ,
    0x1)) & z ) op y.
    
    Matching this patterns allows GCC to generate branchless code for one of
    the functions in coremark.
    
            * match.pd ((x & 0x1) == 0) ? y : z <op> y
            -> (-(typeof(y))(x & 0x1) & z) <op> y.
    
            * gcc.dg/tree-ssa/branchless-cond.c: New test.

Diff:
---
 gcc/match.pd                                    | 24 +++++++++++++++++++++++
 gcc/testsuite/gcc.dg/tree-ssa/branchless-cond.c | 26 +++++++++++++++++++++++++
 2 files changed, 50 insertions(+)

diff --git a/gcc/match.pd b/gcc/match.pd
index f8610e37011..04d4c4c054a 100644
--- a/gcc/match.pd
+++ b/gcc/match.pd
@@ -3492,6 +3492,30 @@ DEFINE_INT_AND_FLOAT_ROUND_FN (RINT)
   (cond (le @0 integer_zerop@1) (negate@2 @0) integer_zerop@1)
   (max @2 @1))
 
+/* ((x & 0x1) == 0) ? y : z <op> y -> (-(typeof(y))(x & 0x1) & z) <op> y */
+(for op (bit_xor bit_ior)
+ (simplify
+  (cond (eq zero_one_valued_p@0
+            integer_zerop)
+        @1
+        (op:c @2 @1))
+  (if (INTEGRAL_TYPE_P (type)
+       && TYPE_PRECISION (type) > 1
+       && (INTEGRAL_TYPE_P (TREE_TYPE (@0))))
+       (op (bit_and (negate (convert:type @0)) @2) @1))))
+
+/* ((x & 0x1) == 0) ? z <op> y : y -> (-(typeof(y))(x & 0x1) & z) <op> y */
+(for op (bit_xor bit_ior)
+ (simplify
+  (cond (ne zero_one_valued_p@0
+            integer_zerop)
+       (op:c @2 @1)
+        @1)
+  (if (INTEGRAL_TYPE_P (type)
+       && TYPE_PRECISION (type) > 1
+       && (INTEGRAL_TYPE_P (TREE_TYPE (@0))))
+       (op (bit_and (negate (convert:type @0)) @2) @1))))
+
 /* Simplifications of shift and rotates.  */
 
 (for rotate (lrotate rrotate)
diff --git a/gcc/testsuite/gcc.dg/tree-ssa/branchless-cond.c b/gcc/testsuite/gcc.dg/tree-ssa/branchless-cond.c
new file mode 100644
index 00000000000..68087ae6568
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/tree-ssa/branchless-cond.c
@@ -0,0 +1,26 @@
+/* { dg-do compile } */
+/* { dg-options "-O2 -fdump-tree-optimized" } */
+
+int f1(unsigned int x, unsigned int y, unsigned int z)
+{
+  return ((x & 1) == 0) ? y : z ^ y;
+}
+
+int f2(unsigned int x, unsigned int y, unsigned int z)
+{
+  return ((x & 1) != 0) ? z ^ y : y;
+}
+
+int f3(unsigned int x, unsigned int y, unsigned int z)
+{
+  return ((x & 1) == 0) ? y : z | y;
+}
+
+int f4(unsigned int x, unsigned int y, unsigned int z)
+{
+  return ((x & 1) != 0) ? z | y : y;
+}
+
+/* { dg-final { scan-tree-dump-times " -" 4 "optimized" } } */
+/* { dg-final { scan-tree-dump-times " & " 8 "optimized" } } */
+/* { dg-final { scan-tree-dump-not "if" "optimized" } } */

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-12-02  8:22 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-02  8:22 [gcc r13-4459] match.pd: rewrite select to branchless expression Richard Biener

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).