public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r13-4610] mklog: do not parse binary file for PR entry
@ 2022-12-12 12:25 Martin Liska
  0 siblings, 0 replies; only message in thread
From: Martin Liska @ 2022-12-12 12:25 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:14d0f82cab37b66e2998b8d0d664711bd1e1371b

commit r13-4610-g14d0f82cab37b66e2998b8d0d664711bd1e1371b
Author: Martin Liska <mliska@suse.cz>
Date:   Mon Dec 12 13:24:25 2022 +0100

    mklog: do not parse binary file for PR entry
    
    contrib/ChangeLog:
    
            * mklog.py: Do not search PR entry in a file that is binary.

Diff:
---
 contrib/mklog.py | 34 ++++++++++++++++++----------------
 1 file changed, 18 insertions(+), 16 deletions(-)

diff --git a/contrib/mklog.py b/contrib/mklog.py
index 3a6ec681b65..358b7fc6b8b 100755
--- a/contrib/mklog.py
+++ b/contrib/mklog.py
@@ -186,23 +186,25 @@ def generate_changelog(data, no_functions=False, fill_pr_titles=False,
             # contains commented code which a note that it
             # has not been tested due to a certain PR or DR.
             this_file_prs = []
-            for line in list(file)[0][0:10]:
-                m = pr_regex.search(line.value)
-                if m:
-                    pr = m.group('pr')
-                    if pr not in prs:
-                        prs.append(pr)
-                        this_file_prs.append(pr.split('/')[-1])
-                else:
-                    m = dr_regex.search(line.value)
+            if not file.is_binary_file:
+                for line in list(file)[0][0:10]:
+                    m = pr_regex.search(line.value)
                     if m:
-                        dr = m.group('dr')
-                        if dr not in prs:
-                            prs.append(dr)
-                            this_file_prs.append(dr.split('/')[-1])
-                    elif dg_regex.search(line.value):
-                        # Found dg-warning/dg-error line
-                        break
+                        pr = m.group('pr')
+                        if pr not in prs:
+                            prs.append(pr)
+                            this_file_prs.append(pr.split('/')[-1])
+                    else:
+                        m = dr_regex.search(line.value)
+                        if m:
+                            dr = m.group('dr')
+                            if dr not in prs:
+                                prs.append(dr)
+                                this_file_prs.append(dr.split('/')[-1])
+                        elif dg_regex.search(line.value):
+                            # Found dg-warning/dg-error line
+                            break
+
             # PR number in the file name
             fname = os.path.basename(file.path)
             m = pr_filename_regex.search(fname)

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-12-12 12:25 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-12 12:25 [gcc r13-4610] mklog: do not parse binary file for PR entry Martin Liska

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).