public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r13-4691] ipa: Avoid looking for IPA-SRA replacements where there are none
@ 2022-12-14 0:04 Martin Jambor
0 siblings, 0 replies; only message in thread
From: Martin Jambor @ 2022-12-14 0:04 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:8a263116d4375892bf67ceaaf2575935cd99edd0
commit r13-4691-g8a263116d4375892bf67ceaaf2575935cd99edd0
Author: Martin Jambor <mjambor@suse.cz>
Date: Wed Dec 14 00:33:06 2022 +0100
ipa: Avoid looking for IPA-SRA replacements where there are none
While modifying the code, I realized that we do look into statements
even when there are no replacements. This patch adds the necessary
early bail-outs to avoid that.
ipa_param_body_adjustments::modify_call_stmt cannot have the same at
the very beginning because calls can still contain otherwise removed
parameters that need to be removed from the statements too.
gcc/ChangeLog:
2022-11-11 Martin Jambor <mjambor@suse.cz>
* ipa-param-manipulation.cc
(ipa_param_body_adjustments::modify_expression): Bail out early if
there are no replacements.
(ipa_param_body_adjustments::modify_assignment): Likewise.
Diff:
---
gcc/ipa-param-manipulation.cc | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/gcc/ipa-param-manipulation.cc b/gcc/ipa-param-manipulation.cc
index e92cfc0b6d5..da19d64cbce 100644
--- a/gcc/ipa-param-manipulation.cc
+++ b/gcc/ipa-param-manipulation.cc
@@ -1762,6 +1762,8 @@ ipa_param_body_adjustments::modify_expression (tree *expr_p, bool convert)
{
tree expr = *expr_p;
+ if (m_replacements.is_empty ())
+ return false;
if (TREE_CODE (expr) == BIT_FIELD_REF
|| TREE_CODE (expr) == IMAGPART_EXPR
|| TREE_CODE (expr) == REALPART_EXPR)
@@ -1809,7 +1811,7 @@ ipa_param_body_adjustments::modify_assignment (gimple *stmt,
tree *lhs_p, *rhs_p;
bool any;
- if (!gimple_assign_single_p (stmt))
+ if (m_replacements.is_empty () || !gimple_assign_single_p (stmt))
return false;
rhs_p = gimple_assign_rhs1_ptr (stmt);
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-12-14 0:04 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-14 0:04 [gcc r13-4691] ipa: Avoid looking for IPA-SRA replacements where there are none Martin Jambor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).