public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Richard Biener <rguenth@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r13-4740] middle-end/108086 - remove PR28238 fix superseeded by PR34018 fix
Date: Fri, 16 Dec 2022 09:29:10 +0000 (GMT)	[thread overview]
Message-ID: <20221216092910.E56633834E26@sourceware.org> (raw)

https://gcc.gnu.org/g:340ddeae6611f6ab524211a009e97a85b4bba549

commit r13-4740-g340ddeae6611f6ab524211a009e97a85b4bba549
Author: Richard Biener <rguenther@suse.de>
Date:   Fri Dec 16 09:46:25 2022 +0100

    middle-end/108086 - remove PR28238 fix superseeded by PR34018 fix
    
    There's quite special code in copy_bb that handles inline substitution
    of a non-invariant address in place of an invariant one that's
    now handled by more generic handling of this case in remap_gimple_op_r
    so this removes the special casing that happens in a hot path, providing
    a small speedup.
    
            PR middle-end/108086
            * tree-inline.cc (copy_bb): Remove handling of (foo *)&this->m
            substitution which is done in remap_gimple_op_r via
            re-gimplifying.

Diff:
---
 gcc/tree-inline.cc | 15 ---------------
 1 file changed, 15 deletions(-)

diff --git a/gcc/tree-inline.cc b/gcc/tree-inline.cc
index 02d8c39c3e8..9fd971a034c 100644
--- a/gcc/tree-inline.cc
+++ b/gcc/tree-inline.cc
@@ -2074,21 +2074,6 @@ copy_bb (copy_body_data *id, basic_block bb,
 	  gimple_duplicate_stmt_histograms (cfun, stmt, id->src_cfun,
 					    orig_stmt);
 
-	  /* With return slot optimization we can end up with
-	     non-gimple (foo *)&this->m, fix that here.  */
-	  if (is_gimple_assign (stmt)
-	      && CONVERT_EXPR_CODE_P (gimple_assign_rhs_code (stmt))
-	      && !is_gimple_val (gimple_assign_rhs1 (stmt)))
-	    {
-	      tree new_rhs;
-	      new_rhs = force_gimple_operand_gsi (&seq_gsi,
-						  gimple_assign_rhs1 (stmt),
-						  true, NULL, false,
-						  GSI_CONTINUE_LINKING);
-	      gimple_assign_set_rhs1 (stmt, new_rhs);
-	      id->regimplify = false;
-	    }
-
 	  gsi_insert_after (&seq_gsi, stmt, GSI_NEW_STMT);
 
 	  if (id->regimplify)

                 reply	other threads:[~2022-12-16  9:29 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221216092910.E56633834E26@sourceware.org \
    --to=rguenth@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).