[gcc r13-4777] aarch64: PR target/108140 Handle NULL target in data intrinsic expansion

[gcc r13-4777] aarch64: PR target/108140 Handle NULL target in data intrinsic expansion

[Kyrylo Tkachov]

https://gcc.gnu.org/g:98756bcbe27647f263f2b312d1d933d70cf56ba9

commit r13-4777-g98756bcbe27647f263f2b312d1d933d70cf56ba9
Author: Kyrylo Tkachov <kyrylo.tkachov@arm.com>
Date:   Mon Dec 19 11:16:47 2022 +0000

    aarch64: PR target/108140 Handle NULL target in data intrinsic expansion
    
    In this PR we ICE when expanding the __rbit builtin with a NULL target rtx.
    I *think* that only happens when the result is unused and hence maybe we shouldn't be expanding
    any RTL at all, but the ICE here is easily fixed by deriving the mode from the type of the expression
    rather than the target.
    
    This patch does that.
    Bootstrapped and tested on aarch64-none-linux-gnu.
    
    gcc/ChangeLog:
    
            PR target/108140
            * config/aarch64/aarch64-builtins.cc
            (aarch64_expand_builtin_data_intrinsic): Handle NULL target.
    
    gcc/testsuite/ChangeLog:
    
            PR target/108140
            * gcc.target/aarch64/acle/pr108140.c: New test.

Diff:
---
 gcc/config/aarch64/aarch64-builtins.cc           |  2 +-
 gcc/testsuite/gcc.target/aarch64/acle/pr108140.c | 15 +++++++++++++++
 2 files changed, 16 insertions(+), 1 deletion(-)

diff --git a/gcc/config/aarch64/aarch64-builtins.cc b/gcc/config/aarch64/aarch64-builtins.cc
index b5330825928..5c9f727b255 100644
--- a/gcc/config/aarch64/aarch64-builtins.cc
+++ b/gcc/config/aarch64/aarch64-builtins.cc
@@ -2648,7 +2648,7 @@ static rtx
 aarch64_expand_builtin_data_intrinsic (unsigned int fcode, tree exp, rtx target)
 {
   expand_operand ops[2];
-  machine_mode mode = GET_MODE (target);
+  machine_mode mode = TYPE_MODE (TREE_TYPE (exp));
   create_output_operand (&ops[0], target, mode);
   create_input_operand (&ops[1], expand_normal (CALL_EXPR_ARG (exp, 0)), mode);
   enum insn_code icode;
diff --git a/gcc/testsuite/gcc.target/aarch64/acle/pr108140.c b/gcc/testsuite/gcc.target/aarch64/acle/pr108140.c
new file mode 100644
index 00000000000..967928a7dca
--- /dev/null
+++ b/gcc/testsuite/gcc.target/aarch64/acle/pr108140.c
@@ -0,0 +1,15 @@
+/* PR target/108140  */
+/* { dg-do compile } */
+/* { dg-options "-O2" } */
+
+#include<arm_acle.h>
+
+int
+main(int argc, char *argv[])
+{
+	unsigned long long input = argc-1;
+	unsigned long long v = __clz(__rbit(input));
+	__builtin_printf("%d %d\n", argc, v >= 64 ? 123 : 456);
+	return 0;
+}
+