public inbox for gcc-cvs@sourceware.org help / color / mirror / Atom feed
From: Kito Cheng <kito@gcc.gnu.org> To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-4864] RISC-V: Fix incorrect annotation Date: Fri, 23 Dec 2022 05:42:33 +0000 (GMT) [thread overview] Message-ID: <20221223054233.DC2B9385703F@sourceware.org> (raw) https://gcc.gnu.org/g:9374f766a75bf898e717a5bbb58199a91528af0b commit r13-4864-g9374f766a75bf898e717a5bbb58199a91528af0b Author: Ju-Zhe Zhong <juzhe.zhong@rivai.ai> Date: Tue Dec 20 07:13:54 2022 +0800 RISC-V: Fix incorrect annotation gcc/ChangeLog: * config/riscv/riscv-vsetvl.cc (anticipatable_occurrence_p): Fix incorrect annotations. (available_occurrence_p): Ditto. (backward_propagate_worthwhile_p): Ditto. (can_backward_propagate_p): Ditto. Diff: --- gcc/config/riscv/riscv-vsetvl.cc | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/gcc/config/riscv/riscv-vsetvl.cc b/gcc/config/riscv/riscv-vsetvl.cc index 0c2ff630e96..72f1e4059ab 100644 --- a/gcc/config/riscv/riscv-vsetvl.cc +++ b/gcc/config/riscv/riscv-vsetvl.cc @@ -186,7 +186,7 @@ anticipatable_occurrence_p (const insn_info *insn, const vector_insn_info dem) /* The only possible operand we care of VSETVL is AVL. */ if (dem.has_avl_reg ()) { - /* The operands shoule not be modified in the basic block prior + /* The operands should not be modified in the basic block prior to the occurrence. */ if (!vlmax_avl_p (dem.get_avl ())) { @@ -223,7 +223,7 @@ available_occurrence_p (const insn_info *insn, const vector_insn_info dem) /* The only possible operand we care of VSETVL is AVL. */ if (dem.has_avl_reg ()) { - /* The operands shoule not be modified in the basic block prior + /* The operands should not be modified in the basic block prior to the occurrence. e.g. bb: @@ -284,7 +284,7 @@ backward_propagate_worthwhile_p (const basic_block cfg_bb, |_________| reaching_out Header is incompatible with reaching_out and the block is loop itself, - we don't backward propagete the local_dem since we can't avoid emit + we don't backward propagate the local_dem since we can't avoid emit vsetvl for the local_dem. */ edge e; edge_iterator ei; @@ -334,10 +334,10 @@ can_backward_propagate_p (const function_info *ssa, const basic_block cfg_bb, insn_info *insn = prop.get_insn (); /* TODO: We don't backward propagate the explict VSETVL here - since we will change vsetvl and vsetvlmax intrinsiscs into - no side effects which can be optimized into optimzal location - by GCC internal PASSes. We only need to support these backward - propagation if vsetvl instrinsics have side effects. */ + since we will change vsetvl and vsetvlmax intrinsics into + no side effects which can be optimized into optimal location + by GCC internal passes. We only need to support these backward + propagation if vsetvl intrinsics have side effects. */ if (vsetvl_insn_p (insn->rtl ())) return false; @@ -369,7 +369,7 @@ can_backward_propagate_p (const function_info *ssa, const basic_block cfg_bb, def_info *def = find_access (insn->uses (), REGNO (reg))->def (); /* If the definition is in the current block, we can't propagate it - acrocss blocks. */ + across blocks. */ if (def->bb ()->cfg_bb ()->index == insn->bb ()->cfg_bb ()->index) { set_info *set = safe_dyn_cast<set_info *> (def); @@ -406,7 +406,7 @@ can_backward_propagate_p (const function_info *ssa, const basic_block cfg_bb, if (def->bb ()->cfg_bb ()->index == cfg_bb->index) return true; - /* Make sure we don't backward propagete the VL/VTYPE info over the + /* Make sure we don't backward propagate the VL/VTYPE info over the definition blocks. */ bool visited_p = false; for (const bb_info *bb : ssa->reverse_bbs ())
reply other threads:[~2022-12-23 5:42 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20221223054233.DC2B9385703F@sourceware.org \ --to=kito@gcc.gnu.org \ --cc=gcc-cvs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).