public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc(refs/users/aoliva/heads/testme)] prevent hash table insertion of deleted entry
@ 2022-12-28 6:44 Alexandre Oliva
0 siblings, 0 replies; 2+ messages in thread
From: Alexandre Oliva @ 2022-12-28 6:44 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:44df4d6301739ec4ecf234a5824b4e5f507117d2
commit 44df4d6301739ec4ecf234a5824b4e5f507117d2
Author: Alexandre Oliva <oliva@gnu.org>
Date: Wed Dec 28 02:21:48 2022 -0300
prevent hash table insertion of deleted entry
Diff:
---
gcc/hash-map.h | 8 +++++---
gcc/hash-set.h | 3 ++-
2 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/gcc/hash-map.h b/gcc/hash-map.h
index 63fa21cf37c..e6ca9cf5e64 100644
--- a/gcc/hash-map.h
+++ b/gcc/hash-map.h
@@ -173,8 +173,9 @@ public:
if (ins)
{
e->m_key = k;
- new ((void *) &e->m_value) Value (v);
- gcc_checking_assert (!Traits::is_empty (*e));
+ new ((void *)&e->m_value) Value (v);
+ gcc_checking_assert (!Traits::is_empty (*e)
+ && !Traits::is_deleted (*e));
}
else
e->m_value = v;
@@ -204,7 +205,8 @@ public:
{
e->m_key = k;
new ((void *)&e->m_value) Value ();
- gcc_checking_assert (!Traits::is_empty (*e));
+ gcc_checking_assert (!Traits::is_empty (*e)
+ && !Traits::is_deleted (*e));
}
if (existed != NULL)
diff --git a/gcc/hash-set.h b/gcc/hash-set.h
index a98121a060e..08e1851d511 100644
--- a/gcc/hash-set.h
+++ b/gcc/hash-set.h
@@ -61,7 +61,8 @@ public:
{
new (e) Key (k);
// Catch attempts to insert e.g. a NULL pointer.
- gcc_checking_assert (!Traits::is_empty (*e));
+ gcc_checking_assert (!Traits::is_empty (*e)
+ && !Traits::is_deleted (*e));
}
return existed;
^ permalink raw reply [flat|nested] 2+ messages in thread
* [gcc(refs/users/aoliva/heads/testme)] prevent hash table insertion of deleted entry
@ 2022-12-28 5:24 Alexandre Oliva
0 siblings, 0 replies; 2+ messages in thread
From: Alexandre Oliva @ 2022-12-28 5:24 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:243552d172e533bce66d84d96b48d01d55d0d8dd
commit 243552d172e533bce66d84d96b48d01d55d0d8dd
Author: Alexandre Oliva <oliva@gnu.org>
Date: Wed Dec 28 02:21:48 2022 -0300
prevent hash table insertion of deleted entry
Diff:
---
gcc/hash-map.h | 8 +++++---
gcc/hash-set.h | 3 ++-
2 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/gcc/hash-map.h b/gcc/hash-map.h
index 63fa21cf37c..e6ca9cf5e64 100644
--- a/gcc/hash-map.h
+++ b/gcc/hash-map.h
@@ -173,8 +173,9 @@ public:
if (ins)
{
e->m_key = k;
- new ((void *) &e->m_value) Value (v);
- gcc_checking_assert (!Traits::is_empty (*e));
+ new ((void *)&e->m_value) Value (v);
+ gcc_checking_assert (!Traits::is_empty (*e)
+ && !Traits::is_deleted (*e));
}
else
e->m_value = v;
@@ -204,7 +205,8 @@ public:
{
e->m_key = k;
new ((void *)&e->m_value) Value ();
- gcc_checking_assert (!Traits::is_empty (*e));
+ gcc_checking_assert (!Traits::is_empty (*e)
+ && !Traits::is_deleted (*e));
}
if (existed != NULL)
diff --git a/gcc/hash-set.h b/gcc/hash-set.h
index a98121a060e..08e1851d511 100644
--- a/gcc/hash-set.h
+++ b/gcc/hash-set.h
@@ -61,7 +61,8 @@ public:
{
new (e) Key (k);
// Catch attempts to insert e.g. a NULL pointer.
- gcc_checking_assert (!Traits::is_empty (*e));
+ gcc_checking_assert (!Traits::is_empty (*e)
+ && !Traits::is_deleted (*e));
}
return existed;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-12-28 6:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-28 6:44 [gcc(refs/users/aoliva/heads/testme)] prevent hash table insertion of deleted entry Alexandre Oliva
-- strict thread matches above, loose matches on Subject: below --
2022-12-28 5:24 Alexandre Oliva
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).